diff options
| author | aarzilli <alessandro.arzilli@gmail.com> | 2015-09-13 12:49:13 +0200 |
|---|---|---|
| committer | Christian Linhart <chris@demorecorder.com> | 2017-01-24 11:02:58 +0100 |
| commit | a909451a51a907ee90969213a56e4e6ecc0b03de (patch) | |
| tree | f54b7c6f5b34e812f1772b8c9ea027b09c88da43 | |
| parent | 95a262e0e66cd88b9d7a133917b3ba70ace77301 (diff) | |
Add missing alignment padding to SetupRequest struct
Fields AuthorizationProtocolName and AuthorizationProtocolData of
SetupRequest should be padded:
http://www.x.org/releases/current/doc/xproto/x11protocol.html#Encoding::Connection_Setup
The problem was discovered by github user pphaneuf while trying to use xgb
to write his own implementation of the connection handshake. Neither xgb
nor xcb actually use code generated for SetupRequest for the handshake,
which is why this bug went unnoticed.
https://github.com/BurntSushi/xgb/issues/24
Alessandro Arzilli.
Reviewed-by: Christian Linhart <chris@demorecorder.com>
| -rw-r--r-- | src/xproto.xml | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/xproto.xml b/src/xproto.xml index 437dc30..dea48df 100644 --- a/src/xproto.xml +++ b/src/xproto.xml @@ -198,9 +198,11 @@ authorization from the authors. <list type="char" name="authorization_protocol_name"> <fieldref>authorization_protocol_name_len</fieldref> </list> + <pad align="4" /> <list type="char" name="authorization_protocol_data"> <fieldref>authorization_protocol_data_len</fieldref> </list> + <pad align="4" /> </struct> <struct name="SetupFailed"> |