summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCort Stratton <cort@google.com>2017-04-27 15:57:21 +0200
committerCort <cdwfs@users.noreply.github.com>2017-04-28 12:07:23 +0200
commitc70c914e514d6ee222af18505e6d4ce8387c3fa2 (patch)
treef365e0f447dea399d1fb256c05662b94e0166eff
parent85e85ed4999c43107f117fa8ff832d40c0137a7a (diff)
layers: Add check for VkFramebuffer dimensions of zero
-rw-r--r--layers/core_validation.cpp19
1 files changed, 19 insertions, 0 deletions
diff --git a/layers/core_validation.cpp b/layers/core_validation.cpp
index da54b48b..5644d5b3 100644
--- a/layers/core_validation.cpp
+++ b/layers/core_validation.cpp
@@ -8646,6 +8646,25 @@ static bool ValidateFramebufferCreateInfo(layer_data *dev_data, const VkFramebuf
pCreateInfo->layers, dev_data->phys_dev_properties.properties.limits.maxFramebufferLayers,
validation_error_map[VALIDATION_ERROR_00415]);
}
+ // Verify FB dimensions are greater than zero
+ if (pCreateInfo->width <= 0) {
+ skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__,
+ VALIDATION_ERROR_02806, "DS",
+ "vkCreateFramebuffer(): Requested VkFramebufferCreateInfo width must be greater than zero. %s",
+ validation_error_map[VALIDATION_ERROR_02806]);
+ }
+ if (pCreateInfo->height <= 0) {
+ skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__,
+ VALIDATION_ERROR_02807, "DS",
+ "vkCreateFramebuffer(): Requested VkFramebufferCreateInfo height must be greater than zero. %s",
+ validation_error_map[VALIDATION_ERROR_02807]);
+ }
+ if (pCreateInfo->layers <= 0) {
+ skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__,
+ VALIDATION_ERROR_02808, "DS",
+ "vkCreateFramebuffer(): Requested VkFramebufferCreateInfo layers must be greater than zero. %s",
+ validation_error_map[VALIDATION_ERROR_02808]);
+ }
return skip;
}