diff options
| author | Thomas Hellstrom <thellstrom@vmware.com> | 2017-09-06 16:27:54 +0200 |
|---|---|---|
| committer | Adam Jackson <ajax@redhat.com> | 2017-09-12 16:13:54 -0400 |
| commit | 4486d199bd3bcb5b2b8ad9bc54eb11604d9bd653 (patch) | |
| tree | ad1f1747e05094cb2e4bc57131f1f82fb2ecd451 | |
| parent | 0fc26310d5b09213c65f50bde444a1758172b016 (diff) | |
glx: Fix visual fbconfig matching with respect to swap method
For the built in visuals, we'd typically select the "best" fbconfig
without considering the swap method. If the client then requests a
specific swap method, say GLX_SWAP_COPY_OML, it may well happen that the
first fbconfig matching requirements would have been paired with the 32-bit
compositing visual, and the client would render a potentially transparent
window.
Fix this so that we try to match fbconfigs with the same swap method to all
built-in visuals. That would guarantee that selecting a specific swap-
method would not influence the chance of getting a compositing visual.
Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>
| -rw-r--r-- | glx/glxscreens.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/glx/glxscreens.c b/glx/glxscreens.c index 37929275e..f000e566d 100644 --- a/glx/glxscreens.c +++ b/glx/glxscreens.c @@ -275,6 +275,15 @@ pickFBConfig(__GLXscreen * pGlxScreen, VisualPtr visual) if (config->visualID != 0) continue; + /* + * If possible, use the same swapmethod for all built-in visual + * fbconfigs, to avoid getting the 32-bit composite visual when + * requesting, for example, a SWAP_COPY fbconfig. + */ + if (config->swapMethod == GLX_SWAP_UNDEFINED_OML) + score += 32; + if (config->swapMethod == GLX_SWAP_EXCHANGE_OML) + score += 16; if (config->doubleBufferMode > 0) score += 8; if (config->depthBits > 0) |