diff options
author | Erik Pilkington <erik.pilkington@gmail.com> | 2016-06-20 20:04:15 +0000 |
---|---|---|
committer | Erik Pilkington <erik.pilkington@gmail.com> | 2016-06-20 20:04:15 +0000 |
commit | 38538eafc60868c67edc0197a54b0265a67f7ace (patch) | |
tree | c08505dbd9a5ef7701708b3c86831a0e0640def9 | |
parent | 5a7e51b93eea78a78d0664cb6a940e1d5abba139 (diff) |
[Sema] Only define function as move assignment when needed
Fixes PR27941, a crash on invalid.
Differential revision: http://reviews.llvm.org/D20923
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@273193 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r-- | lib/Sema/SemaExpr.cpp | 2 | ||||
-rw-r--r-- | test/SemaCXX/cxx0x-defaulted-functions.cpp | 12 |
2 files changed, 13 insertions, 1 deletions
diff --git a/lib/Sema/SemaExpr.cpp b/lib/Sema/SemaExpr.cpp index 6f23115f02..3a33319c37 100644 --- a/lib/Sema/SemaExpr.cpp +++ b/lib/Sema/SemaExpr.cpp @@ -13012,7 +13012,7 @@ void Sema::MarkFunctionReferenced(SourceLocation Loc, FunctionDecl *Func, if (MethodDecl->isDefaulted() && !MethodDecl->isDeleted()) { if (MethodDecl->isCopyAssignmentOperator()) DefineImplicitCopyAssignment(Loc, MethodDecl); - else + else if (MethodDecl->isMoveAssignmentOperator()) DefineImplicitMoveAssignment(Loc, MethodDecl); } } else if (isa<CXXConversionDecl>(MethodDecl) && diff --git a/test/SemaCXX/cxx0x-defaulted-functions.cpp b/test/SemaCXX/cxx0x-defaulted-functions.cpp index 2aaf6197b6..16e20ff496 100644 --- a/test/SemaCXX/cxx0x-defaulted-functions.cpp +++ b/test/SemaCXX/cxx0x-defaulted-functions.cpp @@ -196,3 +196,15 @@ namespace PR15597 { A<int> a; B<int> b; // expected-note {{here}} } + +namespace PR27941 { +struct ExplicitBool { + ExplicitBool &operator=(bool) = default; // expected-error{{only special member functions may be defaulted}} + int member; +}; + +int fn() { + ExplicitBool t; + t = true; +} +} |