diff options
author | Jon TURNEY <jon.turney@dronecode.org.uk> | 2013-06-14 21:28:39 +0100 |
---|---|---|
committer | Jon TURNEY <jon.turney@dronecode.org.uk> | 2013-06-15 12:37:08 +0100 |
commit | b2aaeb911d3fbd305f228abd4d9ec824dc3d5844 (patch) | |
tree | 95e21326e2fb30257bb21f1cc635e461488efb79 | |
parent | ce98c4a02dfb798553b2f632560f92bd1bfe8631 (diff) |
Warning fixes
-rw-r--r-- | wndproc.c | 21 | ||||
-rw-r--r-- | wndproc.h | 2 | ||||
-rw-r--r-- | xevents.c | 6 | ||||
-rw-r--r-- | xevents.h | 2 | ||||
-rw-r--r-- | xwinclip.c | 6 |
5 files changed, 19 insertions, 18 deletions
@@ -57,7 +57,7 @@ */ static int -ProcessXEventsTimeout(HWND hwnd, int iWindow, Display * pDisplay, +ProcessXEventsTimeout(HWND hwnd, Window iWindow, Display * pDisplay, Bool fUseUnicode, int iTimeoutSec) { int iConnNumber; @@ -313,6 +313,7 @@ WindowProc(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam) */ if (!IsClipboardFormatAvailable(CF_TEXT) && !IsClipboardFormatAvailable(CF_UNICODETEXT)) { + Window iOwnerWindow; winDebug("WindowProc - WM_DRAWCLIPBOARD - " "Clipboard does not contain CF_TEXT nor " @@ -357,28 +358,28 @@ WindowProc(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam) winDebug("WindowProc - XSync done.\n"); /* Release PRIMARY selection if owned */ - iReturn = XGetSelectionOwner(pDisplay, XA_PRIMARY); - if (iReturn == iWindow) { + iOwnerWindow = XGetSelectionOwner(pDisplay, XA_PRIMARY); + if (iOwnerWindow == iWindow) { winDebug("WindowProc - WM_DRAWCLIPBOARD - " "PRIMARY selection is owned by us, releasing\n"); XSetSelectionOwner(pDisplay, XA_PRIMARY, None, CurrentTime); } - else if (BadWindow == iReturn || BadAtom == iReturn) + else if (BadWindow == iOwnerWindow || BadAtom == iOwnerWindow) winError("WindowProc - WM_DRAWCLIPBOARD - " "XGetSelectionOwner failed for PRIMARY: %d\n", - iReturn); + iOwnerWindow); /* Release CLIPBOARD selection if owned */ - iReturn = XGetSelectionOwner(pDisplay, atomClipboard); - if (iReturn == iWindow) { + iOwnerWindow = XGetSelectionOwner(pDisplay, atomClipboard); + if (iOwnerWindow == iWindow) { winDebug("WindowProc - WM_DRAWCLIPBOARD - " "CLIPBOARD selection is owned by us, releasing\n"); XSetSelectionOwner(pDisplay, atomClipboard, None, CurrentTime); } - else if (BadWindow == iReturn || BadAtom == iReturn) + else if (BadWindow == iOwnerWindow || BadAtom == iOwnerWindow) winError("WindowProc - WM_DRAWCLIPBOARD - " "XGetSelectionOwner failed for CLIPBOARD: %d\n", - iReturn); + iOwnerWindow); winDebug("WindowProc - WM_DRAWCLIPBOARD: Exit\n"); s_fProcessingDrawClipboard = FALSE; @@ -540,7 +541,7 @@ WindowProc(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam) */ WINBOOL -FlushWindowsMessageQueue(HWND hwnd) +FlushWindowsMessageQueue(void) { MSG msg; @@ -45,7 +45,7 @@ */ WINBOOL -FlushWindowsMessageQueue (HWND hwnd); +FlushWindowsMessageQueue(void); LRESULT CALLBACK WindowProc (HWND hwnd, UINT message, @@ -50,7 +50,7 @@ */ #define CLIP_NUM_SELECTIONS 2 -#define CLIP_OWN_NONE -1 +#define CLIP_OWN_NONE ((unsigned int)-1) #define CLIP_OWN_PRIMARY 0 #define CLIP_OWN_CLIPBOARD 1 @@ -122,14 +122,14 @@ GetLastOwnedSelectionAtom(void) int FlushXEvents (HWND hwnd, Atom atomLocalProperty, Atom atomUTF8String, Atom atomCompoundText, Atom atomTargets, - int iWindow, Display *pDisplay, + Window iWindow, Display *pDisplay, Bool fUseUnicode) { atomClipboard = XInternAtom (pDisplay, "CLIPBOARD", False); /* Process all pending events */ while (XPending(pDisplay)) { - XTextProperty xtpText = { 0 }; + XTextProperty xtpText = { 0, 0, 0, 0 }; XEvent event; XSelectionEvent eventSelection; unsigned long ulReturnBytesLeft; @@ -45,7 +45,7 @@ int FlushXEvents (HWND hwnd, Atom atomLocalProperty, Atom atomUTF8String, Atom atomCompoundText, Atom atomTargets, - int iWindow, Display *pDisplay, + Window iWindow, Display *pDisplay, Bool fUseUnicode); Atom @@ -307,7 +307,7 @@ ClipboardProc(Bool fUnicodeSupport, char *pszDisplay) fUnicodeSupport); /* Pre-flush Windows messages */ - if (!FlushWindowsMessageQueue (hwnd)) + if (!FlushWindowsMessageQueue()) { winError("ClipboardFlushWindowsMessageQueue failed\n"); goto ClipboardProc_Done; @@ -392,7 +392,7 @@ ClipboardProc(Bool fUnicodeSupport, char *pszDisplay) winDebug ("/dev/windows ready, pumping Windows message queue\n"); /* Process Windows messages */ - if (!FlushWindowsMessageQueue (hwnd)) + if (!FlushWindowsMessageQueue()) { winError("FlushWindowsMessageQueue trapped WM_QUIT message, exiting main loop.\n"); break; @@ -416,7 +416,7 @@ ClipboardProc_Done: /* Destroy the Window window (hwnd) */ winDebug("Destroy Windows window\n"); PostMessage(hwnd, WM_DESTROY, 0, 0); - FlushWindowsMessageQueue(hwnd); + FlushWindowsMessageQueue(); } /* Close our X window */ |