Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
The caller of this function may pass NULL as @error so we shouldn't rely on
it.
|
|
|
|
|
|
The for loop is checking for handles[i].name being NULL.
|
|
Those are assigned at the start of every iteration in the 'for' block.
|
|
|
|
|
|
This callback can deal with self being destroyed but it was trying to
access self->priv before early returning.
|
|
|
|
Recent (Markdown-based) gtk-doc doesn't like <code> spanning
more than one line, causing a build failure.
Reviewed-by: Guillaume Desmottes
|
|
The callback returns FALSE so the source will be invalidated.
Recent GLib now raises a critical when attempting to remove an invalid ID,
making some jingle tests failing.
(cherry picked from commit 01fbaec365cc58d6f3de46ce3f54f6413f3ec0f9)
|
|
The callback returns FALSE so the source will be invalidated.
Recent GLib now raises a critical when attempting to remove an invalid ID,
making some jingle tests failing.
|
|
Looks like it's been replaced by gnutls_certificate_credentials_t since a
while.
|
|
|
|
|
|
|
|
|
|
All Automake products automatically depend on their SOURCES and
everything identifiable as a file in their LDADD, unless you set their
DEPENDENCIES, which take precedence (and have "replace", not "add",
semantics). As a result, setting DEPENDENCIES is actually harmful here:
it makes the tests and examples not depend on their own source code!
For the one test that has non-trivial extra dependencies,
use EXTRA_x_DEPENDENCIES, which has the desired semantics.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=67953
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Vivek Dasmohapatra <vivek@collabora.co.uk>
|
|
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
|
|
Similar to telepathy-glib commit 5f8bccce98.
Also use ISO dates in the ChangeLog to reduce diffstat if generated by
someone in a different timezone, and don't bother with --stat.
Again, this is consistent with telepathy-glib.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
|
|
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=67900
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Vivek Dasmohapatra <vivek@collabora.co.uk>
|
|
|
|
The porter test asserted that if you cancelled the sending of a stanza
after it had already been (sent and) received, the send reported
success, not cancellation; and the SASL auth test asserted that if
you closed a connection at around the same time that a cancellable
had been cancelled, the close reported success, not cancellation.
However, recent GLib seems to be either more careful about deferring the
results of async operations to an idle, or more consistent about
reporting the cancellation as an error even if the operation's
success had already been recorded. As a result, these operations
reported cancellation. To avoid that, delay the cancellation a little.
[Mike Ruprecht clarified on IRC that "more consistent about
reporting the cancellation as an error" is one of the changes from GIO
being ported to GTask in 2.36. -smcv]
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=67900
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Vivek Dasmohapatra <vivek@collabora.co.uk>
|
|
The very next thing we did with it was to give it to GSocketConnection,
which would turn on non-blocking again; so this code wasn't doing
anything except harming our portability.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=67900
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Vivek Dasmohapatra <vivek@collabora.co.uk>
|
|
GLib now follows Unicode Corrigendum 9, which clarifies that
libraries shouldn't prohibit non-characters. We were assuming it did.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=67900
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Vivek Dasmohapatra <vivek@collabora.co.uk>
|
|
GSocket configures its underlying fd to be in non-blocking mode, and
implements blocking calls by select()ing (or equivalent) first.
If we break this assumption, most test cases in wocky-connector-test
hang in a recv() that should have been non-blocking.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=67900
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Vivek Dasmohapatra <vivek@collabora.co.uk>
|
|
I'm not sure whether this ever worked correctly, but the build currently
fails on Debian unstable, and this fixes it.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=67875
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
https://bugs.freedesktop.org/show_bug.cgi?id=66262
|
|
https://bugs.freedesktop.org/show_bug.cgi?id=66262
|
|
This reverts commit d8fcf78cf9bbad0b822b3368479cea532f11dc83.
I didn't mean to merge this patch, since it is still pending the
testing/checking Simon mentions on
<https://bugs.freedesktop.org/show_bug.cgi?id=65657#c2>. But I guess it
was locally applied when I merged Tobias' patch.
|
|
For some reason some Google enabled domains have their DNS
not set up correctly. But also working domains like vrfy.org
do not work will with this tool. In order to make it connect
to a XMPP server, the servername and the port can now be given
as parameters.
https://bugs.freedesktop.org/show_bug.cgi?id=64190
|
|
|
|
There seems to be a race condition in Jitsi: if we send a transport-info
full of candidates immediately after sending a session-info, it
sometimes seems to miss the candidates we send it. Waiting until after
it acks our session-initiate seems to do the trick. This is only visible
in an application which only ever sends a single local candidate,
immediately after initiating; it is probably masked in Telepathy by new
candidates trickling in after the call starts as we get STUN replies.
The previous code would call _transmit_candidates when accepting a call,
too, but I don't think this is necessary: in the case where the call is
incoming, wocky_jingle_content_add_candidate() will tell the transport
to send out new candidates as they are added because the state is >
EMPTY.
https://bugs.freedesktop.org/show_bug.cgi?id=65657
|
|
Some were already checked, but as assertions: this is
(now) public library API, so downgrade to g_return_if_fail().
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=65131
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
|
|
wocky_jingle_session_parse() advances the session's state
machine. In particular, it may cause termination, which
causes the session to be removed from the factory's
hash table, which may cause its last ref to be released.
Until recently, this would have gone unnoticed, but
wocky_jingle_session_acknowledge_iq() now emits a signal
from the session (to check whether it has the "is Google
webmail" quirk), and that causes a check that it is in fact
still a valid session object.
Also correct a misleading comment spotted while debugging
this: priv->sessions owns both key and sess.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=65131
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
|
|
The Google webmail client currently starts calls like this:
<iq type="set" ...>
<jingle xmlns="urn:xmpp:jingle:1'"
action="session-initiate" ...>...</jingle>
<session xmlns="http://www.google.com/session"
type="initiate" ...>...</session>
</iq>
(This isn't valid XMPP Core, because 'An IQ stanza of type "get"
or "set" MUST contain exactly one child element', but we can
tolerate it.)
When called, it also echoes the contents of the sender's IQ back to the
sender. It appears that this is how, when it makes an outgoing call,
it determines which dialect the recipient wants to use: the recipient
echoes the appropriate child element.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=65131
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
|
|
This avoids compilation failing because the new(ish) g_thread_new
wasn't available in our target version. telepathy-gabble indirectly
depends on GLib 2.32 anyway, via telepathy-glib 0.20.
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
|
|
|
|
It's checked elsewhere for XMPP 1.0 servers, which can either
use "old SSL" or perform STARTTLS. Legacy Jabber can only use
"old SSL", which is similar to https - connect to a separate port,
typically 5223, and start speaking SSL - so if the connection was
ever going to be encrypted, by this point it already would be.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=65036
Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
|
|
|
|
|
|
These pass because 565f2ed54.
|
|
https://bugs.freedesktop.org/show_bug.cgi?id=61433
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=61792
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
|
|
|
|
|
|
Previously there were a couple of ways this could crash:
* First, if you had a <field type='hidden' var='FORM_TYPE'> with no
<value> child, field->default_value would be NULL so
g_value_get_string (field->default_value)
would critical and return NULL and then you'll be in undefined hell.
* Having fixed that, the code to sort data forms by FORM_TYPE would also
crash because it happens before the FORM_TYPEs have been validated and
used g_value_get_string() without checking and then strcmp()ed the
possibly-NULL result.
I actually have a work-in-progress branch that makes this all a lot less
hairy by adding, among other things, a wocky_data_form_get_form_type()
function which can do the validation for us. But better to fix the
crashes before refactoring them away.
https://bugs.freedesktop.org/show_bug.cgi?id=61433
|
|
https://bugs.freedesktop.org/show_bug.cgi?id=61433
|