Age | Commit message (Collapse) | Author | Files | Lines |
|
https://bugs.freedesktop.org/show_bug.cgi?id=61433
|
|
Notice that some of the paths set priv->result to NULL before completing
it, and some do not. I particularly like the one in
establish_session_recv_cb which assigns priv->result to a tmp variable
but forgets to set priv->result to NULL!
I hoped this would make the connector re-usable between successful
connection attempts, but it doesn't because priv->conn is not cleared
out so it crashes when the stream is establed the second time you call
wocky_connector_connect_async(). At least all the code paths crash
consistently now, though! (Previously if you had connected to a pre-XMPP
Jabber server, wocky_connector_connect_async() did not immediately
reject a second call and would crash later in the same way this now
does.)
|
|
This made the assertion that failed confusing: the message was about
'identity', but it was actually a test of the 'resource' property.
|
|
I changed the default value for WockyConnector:resource to NULL in
5fb069a, but didn't update the test accordingly.
|
|
|
|
Previously, there was no way to leave the resource entirely up to the
server: while the binding code deals correctly with priv->resource being
NULL, it was impossible to make it NULL.
But the random resource generation was broken, too: the RNG was never
seeded so the resource always came out the same.
|
|
|
|
The changes are:
* payment-required is removed;
* not-authorized is added to the schema (it was already defined in
Wocky);
* policy-violation is added. XEP-0086 doesn't define an error code
mapping for it, so I chose 406 "Not Acceptable".
|
|
|
|
|
|
|
|
Lots of the signals had inline comments describing their parameter
lists, but no gtk-doc comments.
|
|
Astonishingly, putting the instance struct before the class struct makes
WockyMuc's signals and properties show up in the generated
documentation.
|
|
|
|
This was renamed to wocky_porter_register_handler_from(), but its
documentation was not updated. Also, the arguments to the function were
wrong: there was a NULL where the JID should be, and the JID appeared
later in the wrong place.
While we're here, fix some formatting earlier on in the same comment. I
think using @ rather than the <!-- --> trick is more legible.
|
|
|
|
This shouldn't affect the outcome of the tests, because we don't check
with any certificates signed by system-wide CAs. But just for
completeness...
Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
|
|
Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
|
|
Just for the sake of people testing against localhost.
Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
|
|
Now that Wocky uses the system-wide CA path by default, let's provide a
way to turn that off if you have some weird requirement.
Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
|
|
This is taken from Gabble, and makes Wocky's certificate checking work
out of the box.
Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
|
|
Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
|
|
If you don't specify a WockyTLSHandler for your WockyConnector, then
WockyTLSConnector creates one for itself. Previously, it defaulted to
silently ignoring SSL errors. Whoops.
Gabble is not affected by this issue, because it provides its own
TLSHandler, and it defaults to telling it to fail on SSL errors.
Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
|
|
These days, JIDs are defined in RFC 6122.
|
|
This makes no functional difference, of course.
|
|
Jonny says:
> I did a git grep -i gabble in your wocky tree and there are loads of
> references that probably shouldn't be around anymore, like header
> guards, comments listing the filename as gabble-jingle-session.c and
> stuff like that. It would be nicer to have less of this.
|
|
Some of the Jingle code itself included wocky.h, which led to include
loops and sadness, so I've changed that too. I also added WOCKY_H_INSIDE
and WOCKY_COMPILATION guards to the Jingle headers.
|
|
Jonny said on <https://bugs.freedesktop.org/show_bug.cgi?id=58198#c1>:
> I see you've moved this stuff into wocky/jingle-*.[ch]. Although I
> hate the "wocky-" prefix as much as anyone else, I think inconsistency
> is even worse. What are your thoughts on this?
I think he is correct.
|
|
|
|
The 'media' variable was not used.
|
|
Some headers are still missing both, but having just G_BEGIN_DECLS
without G_END_DECLS is asking for trouble.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
gtk-doc is a little confused by some of the typedefs being in
jingle-types.h but his is better than nothing.
|
|
I broke this in 9c98c48a, which switched to generating a single file
with all the types.
|
|
|
|
Previously, about-to-initiate would be emitted on every call to
try_session_initiate_or_accept(), whether or not all contents were
actually ready.
This is relatively harmless – it's only used as a hook for sending
directed presence to contacts not subscribed to us – but looked wrong
and is redundant.
|
|
GCC in pedantic mode complains "ISO C does not allow extra ';' outside
of a function".
|
|
|
|
Sigh.
|
|
Aside from removing a few leftover Gabble/telepathy-glib imports, this
is basically mechanical.
|
|
This corresponds to 8bb117691 in Gabble.
|
|
It's called "media" so that GABBLE_DEBUG=media will still work, if that
matters to anyone.
|
|
I'm pretty unhappy about the quirks being added here, but there we go.
|
|
It's used in the Jingle code I'll import shortly.
|