summaryrefslogtreecommitdiff
path: root/tools
diff options
context:
space:
mode:
authorXavier Claessens <xclaesse@gmail.com>2011-11-16 15:21:04 +0100
committerXavier Claessens <xclaesse@gmail.com>2011-11-16 15:56:48 +0100
commit7c77196d24c77a31bb51928ee3875f1161b9fd08 (patch)
tree9baf995b9e648d90abe03121b14235d061691220 /tools
parent769a97c2ed9e6cbfda656a65483f6142423adc36 (diff)
Add coding style check for g_hash_table_destroy and g_array_free usage
Diffstat (limited to 'tools')
-rw-r--r--tools/check-c-style.sh13
1 files changed, 13 insertions, 0 deletions
diff --git a/tools/check-c-style.sh b/tools/check-c-style.sh
index dd62fb7ba..4330b1479 100644
--- a/tools/check-c-style.sh
+++ b/tools/check-c-style.sh
@@ -44,6 +44,19 @@ if grep -En '^ *(static |const |)* *[[:alnum:]_]+\*+([[:alnum:]_]|;|$)' \
fail=1
fi
+if grep -n 'g_hash_table_destroy' "$@"; then
+ echo "^^^ Our coding style is to use g_hash_table_unref"
+ fail=1
+fi
+
+for p in "" "ptr_" "byte_"; do
+ if grep -En "g_${p}array_free \(([^ ,]+), TRUE\)" "$@"; then
+ echo "^^^ Our coding style is to use g_${p}array_unref in the case "
+ echo " the underlying C array is not used"
+ fail=1
+ fi
+done
+
if test -n "$CHECK_FOR_LONG_LINES"
then
if egrep -n '.{80,}' "$@"