summaryrefslogtreecommitdiff
path: root/plugins
diff options
context:
space:
mode:
authorWill Thompson <will@willthompson.co.uk>2013-08-28 08:30:56 +0100
committerWill Thompson <will@willthompson.co.uk>2013-08-28 08:40:20 +0100
commit37eef7721f1d6493bb241618fc6ca73f4d658744 (patch)
treeb5eda7d3bd27b574280c71c602fbc1ad7a0079b2 /plugins
parentb88fa165e855a50fd479aeeb9b8406a526b73773 (diff)
console UI: don't bother preparing the channel
Simon said: > + # We only prepare the channel so that ::invalidated will be emitted > + # when it closes. > > Is this really necessary? I would expect that channels would invalidate > anyway. And he's right: the channel proxy does invalidate without being prepared if the connection goes away, or if someone else calls Close() on the channel.
Diffstat (limited to 'plugins')
-rwxr-xr-xplugins/telepathy-gabble-xmpp-console6
1 files changed, 0 insertions, 6 deletions
diff --git a/plugins/telepathy-gabble-xmpp-console b/plugins/telepathy-gabble-xmpp-console
index 1d131217f..a72c92b55 100755
--- a/plugins/telepathy-gabble-xmpp-console
+++ b/plugins/telepathy-gabble-xmpp-console
@@ -345,7 +345,6 @@ class Window(Gtk.Window):
def __create_cb(self, request, result, _):
try:
channel, context = request.create_and_handle_channel_finish(result)
- channel.prepare_async(None, self.__channel_prepared_cb, None)
channel.connect('invalidated', self.__channel_invalidated_cb)
bus_name = channel.get_bus_name()
@@ -368,11 +367,6 @@ Check that you have the console plugin installed.""" % {
self.__build_ui()
self.show_all()
- def __channel_prepared_cb(self, channel, result, user_data):
- # We only prepare the channel so that ::invalidated will be emitted
- # when it closes.
- pass
-
def __channel_invalidated_cb(self, channel, domain, code, message):
self.infobar.show()
self.infobar_close_button.grab_focus()