summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2011-08-16Remove offensive part of error messageHEADmasterDavid Henningsson1-1/+1
I don't know the exact cause for someone to submit a bug report for this error message: if someone is truly offended by it (if so it is a reminder that some people are more sensitive than others, and I do want those people to feel welcome as well), or if it's a system's check (if this goes through, it shows the system works, and the person might put more work into his/her next patch), or if it's just a bug (after all, it's not that weird to run two instances of PulseAudio?). Either one could be reason enough to apply IMO. Signed-off-by: David Henningsson <david.henningsson@canonical.com>
2011-08-16JACK: Load module-jackdbus-detect in default.paDavid Henningsson1-0/+5
Provides automatic integration with the dbus enabled version of JACK 2. Signed-off-by: David Henningsson <david.henningsson@canonical.com>
2011-08-16alsa-mixer: Add "Line HP Swap" elementDavid Henningsson2-0/+6
The "Line HP Swap" element needs to be set correctly for some Dove boards to work correctly. Thanks to Daniel T Chen for the patch. BugLink: http://bugs.launchpad.net/bugs/451635 Signed-off-by: David Henningsson <david.henningsson@canonical.com>
2011-08-16alsa-mixer: Mute IEC958 optical raw for several Audigy modelsDavid Henningsson1-0/+3
This switch needs to be off for analog output to work on several Audigy cards. Thanks to Daniel T Chen for the patch. BugLink: http://bugs.launchpad.net/bugs/408370 Signed-off-by: David Henningsson <david.henningsson@canonical.com>
2011-08-16build-sys: bump sonameColin Guthrie1-1/+1
2011-08-16core: Unload the modules and cached samples before unref'ing the core.Colin Guthrie2-2/+7
As various modules can subscribe to unlink callbacks unloading some modules may trigger hooks in other modules. The callbacks associated with these hooks could in turn need to use the core in some capacity (e.g. perhaps they are module loading modules (e.g. *-discover, filter-apply or gconf etc. and need to use the core to unload modules they've loaded). This change simply ensures that all modules and cached samples are unloaded before freeing the core.
2011-08-16pactl: Add set-source-output-mute commandMaarten Bosmans2-1/+32
2011-08-16default.pa: Update rtp null sink lineMaarten Bosmans1-1/+1
The description argument has been removed in favour of the more general sink_properties.
2011-08-16Initialise write_volumeMaarten Bosmans2-0/+16
The callback should also be reset in reset_calbacks(). The extra check in _volume_change_apply() is needed because when the sink is unlinked the callbacks are reset, but there still may be pending volume changes.
2011-08-16format: Remove stupid copy-paste-oArun Raghavan1-1/+1
Thanks to Maarten Bosmans for the catch.
2011-08-16introspect: fix source output and sink input docs mix-upJonny Lamb1-4/+4
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
2011-08-16alsa: Set SET_FORMATS flag when appropriateArun Raghavan1-3/+7
2011-08-16sink: Add a SET_FORMATS flagArun Raghavan2-1/+6
This adds a PA_SINK_SET_FORMATS flag to the pa_sink_flags enum, signalling that a sink allows the set of supported formats to be set externally. The idea is for clients to be able to know what sinks support this ability and adapt their UI appropriately.
2011-08-15build-sys: Bump JACK dependency to 0.117.0Arun Raghavan1-1/+1
This version is required since we recently started using jack_free() https://bugs.freedesktop.org/show_bug.cgi?id=38858
2011-08-15conf: Load module-filter-* by defaultArun Raghavan1-0/+7
This loads module-filter-heuristics and module-filter-apply by default so that applications can request filters via properties. Not adding this to system.pa -- the assumption is that people running system mode would want more fine-grained control over such options.
2011-08-15filter-heuristics: Don't force AEC on all phone streamsArun Raghavan1-8/+3
Removing the bit that automatically loads module-echo-cancel for phone streams. Clients need to specifically opt in for this now with filter.want, until we are reasonably certain this won't break other apps (Skype for one, possibly others).
2011-08-15proplist: Make filter properties line up prettilyArun Raghavan1-3/+3
2011-08-15Remind people not to break module-tunnelArun Raghavan1-0/+6
2011-08-15memblock: use built-in functionLu Guanqun1-1/+1
Signed-off-by: Lu Guanqun <guanqun.lu@intel.com>
2011-08-15memblock: fix memory leak when pa_shm_create_rw failsLu Guanqun1-3/+3
Signed-off-by: Lu Guanqun <guanqun.lu@intel.com>
2011-08-15Avoid read from freed memoryMaarten Bosmans1-2/+4
The order of freeing the hashmaps is important here, because otherwise a string used as key is freed before the hashmap is freed. Valgrind reports this as: Invalid read of size 1 at 0x4107042: pa_idxset_string_hash_func (idxset.c:67) by 0x4106026: remove_entry (hashmap.c:93) by 0x41061BF: pa_hashmap_free (hashmap.c:110) by 0x71DD143: pa_dbusiface_core_free (iface-core.c:2105) by 0x71F2169: module_dbus_protocol_LTX_pa__done (module-dbus-protocol.c:595) by 0x406DC51: pa_module_free (module.c:162) by 0x406E01D: pa_module_unload_all (module.c:210) by 0x4068842: core_free (core.c:169) by 0x406FD5D: pa_object_unref (object.c:64) by 0x805224D: pa_core_unref (core.h:184) by 0x805560B: main (main.c:1159) Address 0x4d099c0 is 0 bytes inside a block of size 100 free'd at 0x4025BF0: free (vg_replace_malloc.c:366) by 0x40F128C: pa_xfree (xmalloc.c:131) by 0x71E4CEB: pa_dbusiface_device_free (iface-device.c:1293) by 0x71DCD7E: free_device_cb (iface-core.c:2062) by 0x41061D7: pa_hashmap_free (hashmap.c:113) by 0x71DD125: pa_dbusiface_core_free (iface-core.c:2104) by 0x71F2169: module_dbus_protocol_LTX_pa__done (module-dbus-protocol.c:595) by 0x406DC51: pa_module_free (module.c:162) by 0x406E01D: pa_module_unload_all (module.c:210) by 0x4068842: core_free (core.c:169) by 0x406FD5D: pa_object_unref (object.c:64) by 0x805224D: pa_core_unref (core.h:184)
2011-08-15Initialise variablesMaarten Bosmans5-6/+9
These were detected using clang static analyzer.
2011-08-15Plug some memory leaksMaarten Bosmans4-2/+10
These were detected with valgrind.
2011-08-15module-tunnel: Fix for new protocol versionsMaarten Bosmans1-8/+16
The commit 7ebc5033 resulted in segfaults, because format->plist was not allocated. The solution is not to allocate pa_format_info on the stack, but to properly use pa_format_info_new(). Also a typo regarding pa_tagstruct_putu8 is corrected.
2011-08-15svolume: Make log messages more precise.Tanu Kaskinen4-4/+4
I was looking at a log, and noticed the following lines: I [pulseaudio] svolume_mmx.c: Initialising MMX optimized functions. I [pulseaudio] remap_mmx.c: Initialising MMX optimized remappers. I [pulseaudio] svolume_sse.c: Initialising SSE2 optimized functions. I [pulseaudio] remap_sse.c: Initialising SSE2 optimized remappers. I [pulseaudio] sconv_sse.c: Initialising SSE2 optimized conversions. It seemed odd that some messages were somewhat precise in what functionality was initialized, while the svolume messages told me that they had initialized just "functions". So I made the svolume log messages more precise to match the sconv and remap messages.
2011-08-15daemon-conf: Don't make log files executable.Tanu Kaskinen1-1/+1
2011-08-15sink-input: Avoid fake rewind in corked stateWang Xingchao1-4/+10
sink_input_request_rewind() does nothing if we are in the corked state. Thus do not set the new state untill we have issued the rewind request.
2011-08-15device-restore: Log invalid sink index while setting formatsArun Raghavan1-1/+3
This makes it easier to catch errors when using 'pactl set-sink-formats'
2011-08-15sink: Fix lazy commentingArun Raghavan1-3/+3
2011-08-15pactl: Add a set-sink-formats commandArun Raghavan2-3/+71
This uses the module-device-restore protocol extension to save formats on sinks that support it.
2011-08-15format: Add string to pa_format_info conversion functionArun Raghavan2-10/+65
This will help accept string formats from the command like (so we can set formats using pactl).
2011-08-15format: Make pa_format_info_snprint() more parseableArun Raghavan1-2/+5
Removes the comma as the proplist separator since that makes pa_proplist_from_string() break and prints only the encoding if there are no properties (instead of "<encoding>, (no properties)").
2011-08-15device-restore: Set sink format when possibleArun Raghavan1-6/+41
This implements the actual setting of sink formats when a new sink is added or when the set of available formats changes.
2011-08-15device-restore: Make bools not be bit fieldsArun Raghavan1-3/+3
This makes the pa_bool_t members of userdata not be a single bit field since pa_bool_t can be an int, potentially causing signedness issues in comparisons.
2011-08-15alsa: Implement get/set_formats()Arun Raghavan1-0/+69
This implements the sink get_formats() and set_formats() API in alsa-sink. Modules can use this to allow users to specify what formats their receivers support.
2011-08-15sink: Add a set_formats() APIArun Raghavan2-0/+23
This adds API to let external sources specify what formats a sink supports. Sinks must opt-in to allow this, and can perform some validation if required.
2011-08-12Plug some memory leaks and an invalid readMaarten Bosmans5-3/+6
Note in protocol-dbus.c specifically, method_signatures needs to be freed before method_handlers, because otherwise h->method_name is freed while it is still in use as a key in the method_signatures hashmap.
2011-08-12sink-input: Drop redundant assert (PA_SINK_INPUT_IS_LINKED() checked already)Colin Guthrie1-4/+0
2011-08-12log: Add missing pulsecore/thread.h includeArun Raghavan1-0/+1
2011-08-12i18n: po file fixesLu Guanqun1-1/+1
Signed-off-by: Lu Guanqun <guanqun.lu@intel.com>
2011-08-11alsa: resets POLLOUT eventWang Xingchao2-0/+2
revents marked as POLLOUT|POLLERR|POLLWRNORM in "underrun" case that will trigger unexpected log "ALSA woke us up to write new data to the device, but there was acturally nothing to write...". This patch avoids this log message.
2011-08-11alsa: Update process_usec before going to sleepWang Xingchao2-0/+4
During check_left_to_play/record(), the watermark may increase/decrease. So before sleeping, update the actural sleep time based on latest watermark.
2011-08-11Move i18n.[ch] to src/pulsecoreMaarten Bosmans45-54/+51
The header is used in files troughout the tree and is not included in the public api, so it belongs in pulsecore, not in pulse.
2011-08-11Add some missing format.h includesMaarten Bosmans5-1/+5
2011-08-11Include config.h consistently in source files and not in headersMaarten Bosmans3-8/+4
2011-08-11sample-util: use built-in functionLu Guanqun1-1/+1
use built-in function pa_frame_aligned(). Signed-off-by: Lu Guanqun <guanqun.lu@intel.com>
2011-08-11ext-device-restore: Include format.hColin Guthrie1-0/+1
2011-08-11alsa: Ensure that volumes are written to the h/w at startup.Colin Guthrie2-0/+6
If the device support SYNC_VOLUMES then we need to do an additional push to get the actual change on to the h/w.
2011-08-10alsa-mixer: Fix rounding direction on mixer initialisationColin Guthrie1-2/+2
2011-08-10pactl: Make stat backwards compatible with previous versions.Colin Guthrie2-7/+15
This is not ideal but in order to aid people using it in scripts etc, we will maintain backwards compatibiliy here. Also add a 'short' mode and mention in the man page that this will ultimately become the default at some point in the future.