WIP: gallium/dri2: Don't expose accumulation buffer with RGBA visualexpose-fewer-visuals

Only expose accumluation with BGRA.

1 files changed, 8 insertions, 1 deletions

diff --git a/src/gallium/frontends/dri/dri_screen.c b/src/gallium/frontends/dri/dri_screen.c
index a4e841495a2..43e58e33203 100644
--- a/src/gallium/frontends/dri/dri_screen.c
+++ b/src/gallium/frontends/dri/dri_screen.c
@@ -311,13 +311,20 @@ dri_fill_in_modes(struct dri_screen *screen)
        * that either.  Since the accumulation buffer is itself only 16-bits
        * per channel, there wouldn't be much point.
        *
+       * There's also little point in exposing accumulation with both BGRA and
+       * RGBA ordering.  RGBA seems to only be required for Android, and
+       * there's no accumulation buffer there.  Omit the RGBA + accumulation
+       * configs.
+       *
        * SGI supported accumulation with some deeper unorm formats, but we
        * don't expose visuals for those anyway.
        */
       const bool enable_accumulation =
          mesa_formats[format] != MESA_FORMAT_RGBA_FLOAT16 &&
          mesa_formats[format] != MESA_FORMAT_RGBX_FLOAT16 &&
-         mesa_formats[format] != MESA_FORMAT_B5G6R5_UNORM;
+         mesa_formats[format] != MESA_FORMAT_B5G6R5_UNORM &&
+         mesa_formats[format] != MESA_FORMAT_R8G8B8A8_UNORM &&
+         mesa_formats[format] != MESA_FORMAT_R8G8B8X8_UNORM;
 
       for (i = 1; i <= msaa_samples_max; i++) {
          int samples = i > 1 ? i : 0;