Age | Commit message (Collapse) | Author | Files | Lines |
|
piglit-print-commands.py:41:32: E251 unexpected spaces around keyword / parameter equals
piglit-print-commands.py:41:34: E251 unexpected spaces around keyword / parameter equals
piglit-print-commands.py:42:31: E221 multiple spaces before operator
piglit-print-commands.py:42:31: E251 unexpected spaces around keyword / parameter equals
piglit-print-commands.py:42:34: E251 unexpected spaces around keyword / parameter equals
piglit-print-commands.py:43:32: E251 unexpected spaces around keyword / parameter equals
piglit-print-commands.py:43:34: E251 unexpected spaces around keyword / parameter equals
piglit-print-commands.py:44:29: E221 multiple spaces before operator
piglit-print-commands.py:44:29: E251 unexpected spaces around keyword / parameter equals
piglit-print-commands.py:44:34: E251 unexpected spaces around keyword / parameter equals
piglit-print-commands.py:44:80: E501 line too long (89 > 79 characters)
piglit-print-commands.py:57:24: E128 continuation line under-indented for visual indent
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Brian Paul <brianp@vmware.com>
Reviewed-by: Dylan Baker <dylanx.c.baker@intel.com>
|
|
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=85079
Signed-off-by: Dylan Baker <dylanx.c.baker@intel.com>
|
|
Some test profiles require configuration values from piglit.conf before
they can enumerate the tests.
Signed-off-by: Thomas Wood <thomas.wood@intel.com>
Reveiwed-by: Dylan Baker <baker.dylan.c@gmail.com>
|
|
Environment doesn't really describe what the class is (although,
honestly it's a pretty bad class design), but Options comes much closer
to what it is.
v7: - update piglit-print-commands.py
- replace instance name 'env' with 'opts'
- rename Test.ENV to Test.OPTS
Signed-off-by: Dylan Baker <baker.dylan.c@gmail.com>
Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu>
|
|
This replaces #!/usr/bin/env python with #!/usr/bin/env python2, which
fixes the build on archlinux. This has been proposed before, but at that
time debian didn't provide a python2 executable, so it would break
debian. Debian sid as of today provides python2.
v2: - fix piglit as well
Signed-off-by: Dylan Baker <baker.dylan.c@gmail.com>
Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu>
|
|
Signed-off-by: Shuang He <shuang.he@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78719
reviewed-by: Dylan Baker <baker.dylan.c@gmail.com>
|
|
This is a more pythonic name for this method.
This patch was created with the following shell command:
find . -name '*py' | \
xargs sed -i -e 's!loadTestProfile!load_test_profile!g'
Signed-off-by: Dylan Baker <baker.dylan.c@gmail.com>
|
|
There was one consumer of TestProfile related functions that wasn't
converted, piglit-print-commands.py. This fix is trivial
Signed-off-by: Dylan Baker <baker.dylan.c@gmail.com>
|
|
Rather than have 2 base classes, let's just have one.
v2: - remove test that no longer is valid
v3: - fix igt using ExecTest instead of Test
- fix Test setting two different run methods
- fix piglit-print-commands.py, which also relied on ExecTest
Signed-off-by: Dylan Baker <baker.dylan.c@gmail.com>
|
|
One of the biggest changes between python2 and python3 is that print
changed from a statement to a function. This change was backported to
python2 in the __future__ module, and this patch makes that conversation
to ease the transition from python2 to python3.
v2: - Replace dict comprehension with dict(generator). This is for
python 2.6 compatability
Signed-off-by: Dylan Baker <baker.dylan.c@gmail.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com> (v1)
|
|
|
|
simplejson is a native code version of the json module in python
(the json module in core python implements the simplejson api), which
means that simplejson can be used in place of the json module, but it
performs much better. This patch attempts to load simplejson, and falls
back to normal json if it fails.
In the summary path on a single run of quick.tests, simplejson is about
3-4 seconds faster than json, ~7 seconds vs ~11 seconds.
Signed-off-by: Dylan Baker <baker.dylan.c@gmail.com>
|
|
This patch removes deprecated options from piglit-print-commands.
Signed-off-by: Dylan Baker <baker.dylan.c@gmail.com>
|
|
Signed-off-by: Dylan Baker <baker.dylan.c@gmail.com>
Reviewed-by: Chad Versace <chad.versace@linux.intel.com>
|
|
Relative executable paths introduce no new requirements. The tests'
arguments are already relative, so they already imply that the commands
must be run from the top of the piglit directory for printed commands to
work properly.
The benefit of relative executable paths is that it makes it easier to
run the tests on a different directory later on.
Reviewed-by: Brian Paul <brianp@vmware.com>
|
|
PEP 8 specifies that all indents should be either 4 spaces or an
equivalent tab indent, but without mixing tabs and spaces, with a
preference for spaces over tabs because they are absolute. Tabs and
spaces should not be mixed because they lead to expected indent level
errors.
Currently piglit uses a mixture of spaces and tabs, this patch uses the
python tools reindent.py to convert the tabs to spaces.
Signed-off-by: Dylan Baker <baker.dylan.c@gmail.com>
v2: Rebase against master, fix apparent unintentional unindentation of
help text in piglit-summary.py (changes by anholt)
Reviewed-by: Eric Anholt <eric@anholt.net>
|
|
Move the re.compile into the core.Enivironment constructor, which
reduces code duplication. It also allows us to pass environment data on
initilization of the object, rather that having edit it's attributes
individually.
V2: - Does not remove deprecated options, only marks them as such
V3: - Fixes deperecated warning for tests from V2 always being triggered
Signed-off-by: Dylan Baker <baker.dylan.c@gmail.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
|
|
This change gets us cleaner, more readable argument parsing code.
Another advantage of this approach is that it automatically generates
help menus, which means options will not be implemented without a help
entry (like --resume)
V2: - Does not remove deprecated options, only marks them as deprecated
V3: - Fixes deprecated warning for tests from V2 always being triggered
Signed-off-by: Dylan Baker <baker.dylan.c@gmail.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
|
|
This program does not support resume, but has some code copied from
piglit-run.py for resuming interupted runs, so drop it.
Signed-off-by: Dylan Baker <baker.dylan.c@gmail.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
|
|
Excluding tests already uses a similar syntax (--exclude-tests), so this
is more consistent.
V2: - Leaves --tests option, but marks it as deprecated
Signed-off-by: Dylan Baker <baker.dylan.c@gmail.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
|
|
calling.
Because of the modification of function loadTestProfile's defination,
fix the parameters when calling it.
This makes piglit-print-commands.py work again, which was broken by
commit 9a4bc09db00dde770a648a9fccfc249e465bc262.
Signed-off-by: Yi Sun <yi.sun@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
|
|
Reviewed-by: Chad Versace <chad.versace@linux.intel.com>
|
|
This prints a list of all the tests and how to run them:
piglit test name ::: /path/to/piglit/bin/program <args>
glean test name ::: PIGLIT_TEST='...' /path/to/piglit/bin/glean -v -v -v ...
This may be of use to our QA team, who currently use their own
infrastructure for running test suites. Having their runner launch
piglit-run.py, which parses all.tests, for every test case, is
incredibly expensive.
This is not meant to be a long term solution.
Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Acked-by: Jose Fonseca <jfonseca@vmware.com>
|