cleanup: fix warnings related to implicit declarations and return values

Signed-off-by: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>

14 files changed, 20 insertions, 16 deletions

diff --git a/InfraStack/OSAgnostic/Common/CommonServices/Messenger.c b/InfraStack/OSAgnostic/Common/CommonServices/Messenger.c
index a07bb63..54c920e 100644
--- a/InfraStack/OSAgnostic/Common/CommonServices/Messenger.c
+++ b/InfraStack/OSAgnostic/Common/CommonServices/Messenger.c
@@ -28,6 +28,7 @@ ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
 POSSIBILITY OF SUCH DAMAGE.
 
 ***************************************************************************/
+#include <unistd.h>
 #include "wimax_osal_primitives.h"
 
 #include "Messenger.h"
diff --git a/InfraStack/OSAgnostic/Common/CommonServices/Queue.c b/InfraStack/OSAgnostic/Common/CommonServices/Queue.c
index 6c06bb0..b5f27f1 100644
--- a/InfraStack/OSAgnostic/Common/CommonServices/Queue.c
+++ b/InfraStack/OSAgnostic/Common/CommonServices/Queue.c
@@ -28,6 +28,7 @@ ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
 POSSIBILITY OF SUCH DAMAGE.
 
 ***************************************************************************/
+#include <unistd.h>
 #include "wimax_osal_primitives.h"
 #include "Queue.h"
 #include "CommonServices.h"
diff --git a/InfraStack/OSAgnostic/Common/CommonServices/VersionHandshake.c b/InfraStack/OSAgnostic/Common/CommonServices/VersionHandshake.c
index 4c800b2..bc53cf9 100644
--- a/InfraStack/OSAgnostic/Common/CommonServices/VersionHandshake.c
+++ b/InfraStack/OSAgnostic/Common/CommonServices/VersionHandshake.c
@@ -29,6 +29,7 @@ POSSIBILITY OF SUCH DAMAGE.
 
 ***************************************************************************/
 // Project
+#include <unistd.h>
 #include "PipeHandlerInternal.h"
 #include "VersionUtils.h"
 #include "L5OpCodes.h"	
@@ -95,4 +96,4 @@ VERSION_RESULT PIPE_HANDLER_ValidateOwnVersion(L5_CONNECTION l5ConnID)
 	}	
 
 	return validationResult;
-}
\ No newline at end of file
+}
diff --git a/InfraStack/OSAgnostic/Common/L5Common/EventSubscribers.c b/InfraStack/OSAgnostic/Common/L5Common/EventSubscribers.c
index d8dc2f2..9262520 100644
--- a/InfraStack/OSAgnostic/Common/L5Common/EventSubscribers.c
+++ b/InfraStack/OSAgnostic/Common/L5Common/EventSubscribers.c
@@ -28,6 +28,7 @@ ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
 POSSIBILITY OF SUCH DAMAGE.
 
 ***************************************************************************/
+#include <unistd.h>
 #include "EventSubscribers.h"
 
 #include "CommonServices.h"
@@ -155,4 +156,4 @@ void SendEventToSubscribers(List *pList, wmx_CtrlStatus_t status)
 		handle = Iterator_GetNext(pList, handle, (void**)&pTempSub);
 	}
 	FreeIterator(pList);
-}
\ No newline at end of file
+}
diff --git a/InfraStack/OSAgnostic/Common/L5Common/IndicatorsSubscribers.c b/InfraStack/OSAgnostic/Common/L5Common/IndicatorsSubscribers.c
index f6d3067..41bb044 100644
--- a/InfraStack/OSAgnostic/Common/L5Common/IndicatorsSubscribers.c
+++ b/InfraStack/OSAgnostic/Common/L5Common/IndicatorsSubscribers.c
@@ -28,6 +28,7 @@ ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
 POSSIBILITY OF SUCH DAMAGE.
 
 ***************************************************************************/
+#include <unistd.h>
 #include "IndicatorsSubscribers.h"
 
 #include "CommonServices.h"
diff --git a/InfraStack/OSAgnostic/Common/WrappersCommon/WrappersUtils.c b/InfraStack/OSAgnostic/Common/WrappersCommon/WrappersUtils.c
index 9241e24..c0a40e3 100644
--- a/InfraStack/OSAgnostic/Common/WrappersCommon/WrappersUtils.c
+++ b/InfraStack/OSAgnostic/Common/WrappersCommon/WrappersUtils.c
@@ -29,7 +29,7 @@ POSSIBILITY OF SUCH DAMAGE.
 
 ***************************************************************************/
 #include "wimax_osal_primitives.h"
-
+#include <unistd.h>
 #include "Services_Ctrl.h"
 #include "WrappersUtils.h"
 #include "WrappersCommon.h"
@@ -342,4 +342,4 @@ EXPORT wmx_Status_t wmx_UnregisterOnDriverReport(
 {
 	return wmx_UnregisterOnAgentIndication( 
 		cnt, L5_TARGET_L4_PROXY, L4_PROXY_OPCODE_UNREGISTER_L4_INDICATION, ind, dispatcher_funcs, conn );
-}
\ No newline at end of file
+}
diff --git a/InfraStack/OSAgnostic/Product/AppSrvInfra/Act.c b/InfraStack/OSAgnostic/Product/AppSrvInfra/Act.c
index 478ad82..5c09987 100644
--- a/InfraStack/OSAgnostic/Product/AppSrvInfra/Act.c
+++ b/InfraStack/OSAgnostic/Product/AppSrvInfra/Act.c
@@ -114,9 +114,6 @@ static BOOL useTraces = FALSE;
 static BOOL isActStarted = FALSE;
 static BOOL isRemote = FALSE;
 
-extern struct L4Configurations;
-
-
 #define INTIALIZE(x)	&x##_Initialize()
 #define FINALIZE(x)		&x##_Finalize()
 #define START(x)		&x##_Start()
diff --git a/InfraStack/OSAgnostic/Product/AppSrvInfra/L4MsgProxy.c b/InfraStack/OSAgnostic/Product/AppSrvInfra/L4MsgProxy.c
index 1add118..2ca1915 100644
--- a/InfraStack/OSAgnostic/Product/AppSrvInfra/L4MsgProxy.c
+++ b/InfraStack/OSAgnostic/Product/AppSrvInfra/L4MsgProxy.c
@@ -29,6 +29,7 @@ POSSIBILITY OF SUCH DAMAGE.
 
 ***************************************************************************/
 //#pragma warning(disable : 4201) // warning C4201: nonstandard extension used : nameless struct/union
+#include <unistd.h>
 
 #include "Services_Ctrl.h"
 #include "L5Common.h"
diff --git a/InfraStack/OSAgnostic/Product/AppSrvInfra/L5Dispatcher.c b/InfraStack/OSAgnostic/Product/AppSrvInfra/L5Dispatcher.c
index e59f3d6..acf6e58 100644
--- a/InfraStack/OSAgnostic/Product/AppSrvInfra/L5Dispatcher.c
+++ b/InfraStack/OSAgnostic/Product/AppSrvInfra/L5Dispatcher.c
@@ -31,6 +31,7 @@ POSSIBILITY OF SUCH DAMAGE.
 //////////////////////////////////////////////////////////////////////////
 // OSAL
 #include "wimax_osal_primitives.h"
+#include <unistd.h>
 
 // Project
 #include "L5Dispatcher.h"
diff --git a/InfraStack/OSAgnostic/Product/Instrumantation/MocMsgProxy/MocMsgProxy.h b/InfraStack/OSAgnostic/Product/Instrumantation/MocMsgProxy/MocMsgProxy.h
index a6a04c3..1115af4 100644
--- a/InfraStack/OSAgnostic/Product/Instrumantation/MocMsgProxy/MocMsgProxy.h
+++ b/InfraStack/OSAgnostic/Product/Instrumantation/MocMsgProxy/MocMsgProxy.h
@@ -73,8 +73,6 @@ static OSAL_critical_section perAppInfoGuard;
 static BOOL initialized;
 
 
-static void MyPrintf(const char* format, ...);
-
 EXTERN_C EXPORT APPSRV_INIT_ST MocMsgProxy_Initialize(tL5DispatcherFunctions *L5disp, tUtilityFunctions *UtilFn);
 EXTERN_C EXPORT BOOL MocMsgProxy_Start();
 EXTERN_C EXPORT BOOL MocMsgProxy_Stop();
@@ -114,4 +112,4 @@ void MocMsgProxy_EventHandler(
 	void *pvUserContext );
 
 
-#endif // _MOC_MSG_PROXY_H_
\ No newline at end of file
+#endif // _MOC_MSG_PROXY_H_
diff --git a/InfraStack/OSAgnostic/WiMax/Agents/NDnS/Source/NDnSAgent.c b/InfraStack/OSAgnostic/WiMax/Agents/NDnS/Source/NDnSAgent.c
index 87321c7..2bef36c 100644
--- a/InfraStack/OSAgnostic/WiMax/Agents/NDnS/Source/NDnSAgent.c
+++ b/InfraStack/OSAgnostic/WiMax/Agents/NDnS/Source/NDnSAgent.c
@@ -58,6 +58,7 @@
 #include "wimax_osal_services_cmn.h"
 #include "wimax_osal_ip_services.h"
 #include "wimax_osal_crypt_services.h"
+#include <math.h>
 
 typedef wmx_Status_t (*DualFlushOp)();
 
diff --git a/InfraStack/OSAgnostic/WiMax/Wrappers/Apdo/AES_CCM.c b/InfraStack/OSAgnostic/WiMax/Wrappers/Apdo/AES_CCM.c
index 87c4aec..dea711b 100644
--- a/InfraStack/OSAgnostic/WiMax/Wrappers/Apdo/AES_CCM.c
+++ b/InfraStack/OSAgnostic/WiMax/Wrappers/Apdo/AES_CCM.c
@@ -34,6 +34,8 @@ POSSIBILITY OF SUCH DAMAGE.
 
 #include "TraceModule.h"
 
+#include <math.h>
+#include <stdlib.h>
 #include "AES_CCM.h"
 #include "TypesProxy.h"
 #include "AES.h"
diff --git a/InfraStack/OSDependent/Linux/wimaxcu/wimaxcu_main.c b/InfraStack/OSDependent/Linux/wimaxcu/wimaxcu_main.c
index 1512a9b..faf0f36 100644
--- a/InfraStack/OSDependent/Linux/wimaxcu/wimaxcu_main.c
+++ b/InfraStack/OSDependent/Linux/wimaxcu/wimaxcu_main.c
@@ -324,7 +324,7 @@ void wimaxcu_stop_signal_handler(int sig)
 	wmxStatus = CmdStopScan(&gbl_device_id);
 	if (WIMAX_API_RET_SUCCESS != wmxStatus) {
 		printf("ERROR: Failed to stop scanning.\n");
-		return 1;
+		return;
 	}
 	(void)signal(SIGINT,wimaxcu_stop);
 	
@@ -362,7 +362,6 @@ int main(int argc, char *argv[])
 	WIMAX_API_RET wmxStatus;
 	
 	parsed_cmd out_cmd;
-	struct sigaction sa;
 
 	//checking user priviledge
 	//Disabled permission checking so non-root can run it
diff --git a/InfraStack/OSDependent/Linux/wimaxcu/wimaxcu_set_get_op.c b/InfraStack/OSDependent/Linux/wimaxcu/wimaxcu_set_get_op.c
index bf32a04..fa74c71 100644
--- a/InfraStack/OSDependent/Linux/wimaxcu/wimaxcu_set_get_op.c
+++ b/InfraStack/OSDependent/Linux/wimaxcu/wimaxcu_set_get_op.c
@@ -710,14 +710,14 @@ void wimaxcu_get_odm_info(WIMAX_API_DEVICE_ID_P p_device_id)
 	{
 		printf("ERROR: Failed to get ODM version\n");
 		PrintWmxStatus(wmxStatus);
-		return 1;
+		return;
 	}
 	printf("ODM Information\n");
 	for(i = 0; i < bin_blob_size; i++) {
 		printf("%c",bin_blob[i]);	
 	}
 	printf("\n");
-	return 0;
+	return;
 }
 
 void wimaxcu_get_nvm_info(WIMAX_API_DEVICE_ID_P p_device_id)
@@ -730,12 +730,12 @@ void wimaxcu_get_nvm_info(WIMAX_API_DEVICE_ID_P p_device_id)
 	{
 		printf("ERROR: Failed to get NVM image version\n");
 		PrintWmxStatus(wmxStatus);
-		return 1;
+		return;
 	}
 	
 	PrintNVMImageVersion(&NVMImageVersion);
 	
-	return 0;
+	return;
 }
 
 void wimaxcu_get_ip_interface(WIMAX_API_DEVICE_ID_P p_device_id)