summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDJ Lucas <dj@linuxfromscratch.org>2008-09-01 09:42:48 -0700
committerDan Nicholson <dbn.lists@gmail.com>2008-09-01 09:43:04 -0700
commite27b5633d4e7d4790c8f1991650d1411acf94b80 (patch)
treee2ddfc1210e0cba411590c929999393e634dc0a2
parent23037b6b0ef54e3b0c508a05860d9af2070ee2b3 (diff)
Fix handling of optional dependenciesinitd-tools-0.1.2
When an missing dependency from Should-Start or Should-Stop was encountered, all the processing was being skipped instead just moving to the next dependency.
-rw-r--r--lib/rdep.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/lib/rdep.c b/lib/rdep.c
index 9e4c1ab..a143694 100644
--- a/lib/rdep.c
+++ b/lib/rdep.c
@@ -260,13 +260,15 @@ static bool _recurse_deps(initd_list_t *pool, initd_sk_t sk,
if (!cip) {
/* Don't error if the caller said this was an
* optional dependency. */
- if (!optional) {
+ if (optional)
+ continue;
+ else {
fprintf(stderr,
"No init script provides %s\n",
cstr);
success = false;
+ goto out;
}
- goto out;
}
if (rdep_verbose) {