summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBenjamin Franzke <benjaminfranzke@googlemail.com>2011-04-18 13:26:32 +0200
committerBenjamin Franzke <benjaminfranzke@googlemail.com>2011-04-18 13:27:55 +0200
commitf59bf5441af713327418118dc537103804a681f7 (patch)
tree5165a634c77ce16714fa598dfa5afbd2ed80eb33
parentef061782ea5b8aac7c85f6e2096fdf67f1025fe9 (diff)
Set BAD_ATTRIBUTE error for invalid attribs in *_{get,set}_attribute*
-rw-r--r--src/wfdevent.c1
-rw-r--r--src/wfdpipeline.c2
-rw-r--r--src/wfdport.c12
3 files changed, 14 insertions, 1 deletions
diff --git a/src/wfdevent.c b/src/wfdevent.c
index a1efa9a..96ed851 100644
--- a/src/wfdevent.c
+++ b/src/wfdevent.c
@@ -198,6 +198,7 @@ wfd_event_get_attribi(struct wfd_device *device,
case WFD_EVENT_PORT_ATTACH_STATE:
return event->attach_state;
default:
+ wfd_device_set_error(device, WFD_ERROR_BAD_ATTRIBUTE);
break;
}
diff --git a/src/wfdpipeline.c b/src/wfdpipeline.c
index 91ac978..c4b8296 100644
--- a/src/wfdpipeline.c
+++ b/src/wfdpipeline.c
@@ -200,6 +200,7 @@ wfd_pipeline_set_attribiv(struct wfd_device *device,
count * (sizeof *value));
break;
default:
+ wfd_device_set_error(device, WFD_ERROR_BAD_ATTRIBUTE);
break;
}
}
@@ -223,6 +224,7 @@ wfd_pipeline_get_attribiv(struct wfd_device *device,
count * (sizeof *value));
break;
default:
+ wfd_device_set_error(device, WFD_ERROR_BAD_ATTRIBUTE);
break;
}
}
diff --git a/src/wfdport.c b/src/wfdport.c
index 82f2cf9..c94a32c 100644
--- a/src/wfdport.c
+++ b/src/wfdport.c
@@ -297,6 +297,7 @@ wfd_port_get_attribi(struct wfd_device *device,
case WFD_PORT_PROTECTION_ENABLE:
return WFD_FALSE;
default:
+ wfd_device_set_error(device, WFD_ERROR_BAD_ATTRIBUTE);
break;
}
@@ -357,6 +358,7 @@ wfd_port_get_attribiv(struct wfd_device *device,
wfd_port_get_bindable_pipelines(device, port, count, value);
break;
default:
+ wfd_device_set_error(device, WFD_ERROR_BAD_ATTRIBUTE);
break;
}
}
@@ -381,6 +383,7 @@ wfd_port_get_attribfv(struct wfd_device *device,
value[0] = value[1] = value[2] = 0.0;
break;
default:
+ wfd_device_set_error(device, WFD_ERROR_BAD_ATTRIBUTE);
break;
}
}
@@ -420,7 +423,9 @@ wfd_port_set_attribi(struct wfd_device *device,
case WFD_PORT_ROTATION:
/* ignored as FILL_PORT_AREA = true */
case WFD_PORT_BACKGROUND_COLOR:
+ break;
default:
+ wfd_device_set_error(device, WFD_ERROR_BAD_ATTRIBUTE);
break;
}
}
@@ -442,7 +447,9 @@ wfd_port_set_attribiv(struct wfd_device *device,
break;
/* ignored as FILL_PORT_AREA = true */
case WFD_PORT_BACKGROUND_COLOR:
+ break;
default:
+ wfd_device_set_error(device, WFD_ERROR_BAD_ATTRIBUTE);
break;
}
}
@@ -457,7 +464,9 @@ wfd_port_set_attribfv(struct wfd_device *device,
switch (attribute) {
/* ignored as FILL_PORT_AREA = true */
case WFD_PORT_BACKGROUND_COLOR:
+ break;
default:
+ wfd_device_set_error(device, WFD_ERROR_BAD_ATTRIBUTE);
break;
}
}
@@ -535,8 +544,8 @@ wfd_port_mode_get_attribi(struct wfd_device *device,
return WFD_ROTATION_SUPPORT_NONE;
case WFD_PORT_MODE_INTERLACED:
return !!(mode->flags & DRM_MODE_FLAG_INTERLACE);
-
default:
+ wfd_device_set_error(device, WFD_ERROR_BAD_ATTRIBUTE);
break;
}
@@ -559,6 +568,7 @@ wfd_port_mode_get_attribf(struct wfd_device *device,
case WFD_PORT_MODE_REFRESH_RATE:
return (WFDfloat) mode->vrefresh;
default:
+ wfd_device_set_error(device, WFD_ERROR_BAD_ATTRIBUTE);
break;
}