summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPhilip Withnall <philip.withnall@collabora.co.uk>2014-05-16 23:08:10 +0100
committerPhilip Withnall <philip.withnall@collabora.co.uk>2014-05-26 08:39:40 +0100
commitd3fd88ddd54dd533b09e8782a8ffc0dc9f6f0571 (patch)
tree181adacbaec69dc6e6c3ca06a99249f1a262c923
parent570b27b9acbf6e6f31ab0f9a31a4cce60f4d228a (diff)
gtestutils: Error out if /dev/null stdin redirection fails
https://bugzilla.gnome.org/show_bug.cgi?id=730189
-rw-r--r--glib/gtestutils.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/glib/gtestutils.c b/glib/gtestutils.c
index 88a6fc0d7..e67078d53 100644
--- a/glib/gtestutils.c
+++ b/glib/gtestutils.c
@@ -2680,7 +2680,11 @@ g_test_trap_fork (guint64 usec_timeout,
close (stdout_pipe[0]);
close (stderr_pipe[0]);
if (!(test_trap_flags & G_TEST_TRAP_INHERIT_STDIN))
- fd0 = g_open ("/dev/null", O_RDONLY, 0);
+ {
+ fd0 = g_open ("/dev/null", O_RDONLY, 0);
+ if (fd0 < 0)
+ g_error ("failed to open /dev/null for stdin redirection");
+ }
if (sane_dup2 (stdout_pipe[1], 1) < 0 || sane_dup2 (stderr_pipe[1], 2) < 0 || (fd0 >= 0 && sane_dup2 (fd0, 0) < 0))
g_error ("failed to dup2() in forked test program: %s", g_strerror (errno));
if (fd0 >= 3)