diff options
| author | Alan Coopersmith <alan.coopersmith@oracle.com> | 2012-02-04 09:05:08 -0800 |
|---|---|---|
| committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2012-02-06 20:44:51 +0100 |
| commit | e61b917134527500c08900f5f71d996a9cbc5735 (patch) | |
| tree | 856e1f334524223949a48a60f95fba1e366297f1 | |
| parent | 3d46ca8c4d43adfd9827b4b21648a4fddd03c254 (diff) | |
Move free(cmd) to after last use of cmd in intel_gpu_top
Error: Use after free (CWE 416)
Use after free of pointer 'cmd' in call to fprintf
at line 496 of tools/intel_gpu_top.c in function 'main'.
Previously freed at line 491 with free.
[ This bug was found by the Parfait 0.4.2 bug checking tool.
For more information see http://labs.oracle.com/projects/parfait/ ]
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
| -rw-r--r-- | tools/intel_gpu_top.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c index bad47942..5a016c76 100644 --- a/tools/intel_gpu_top.c +++ b/tools/intel_gpu_top.c @@ -488,7 +488,6 @@ int main(int argc, char **argv) else if (child_pid == 0) { int res; res = system(cmd); - free(cmd); if (res < 0) perror("running command"); if (output) { @@ -496,6 +495,7 @@ int main(int argc, char **argv) fprintf(output, "# %s exited with status %d\n", cmd, res); fflush(output); } + free(cmd); exit(0); } else { free(cmd); |