summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoel Schopp <jschopp@austin.ibm.com>2010-07-21 15:05:16 -0500
committerAurelien Jarno <aurelien@aurel32.net>2010-07-30 23:05:51 +0200
commitca1d6ac657ff1cebd689b5d93784402e7ceb52c3 (patch)
tree44f55f753788a35b480d2e7a00623e57c5d70cd8
parent61bca2942c94bcb1d763dd5fff8cdbd0a05e9ae0 (diff)
fix variable type in qemu-io.c
The variable len can get a negative return value from cvtnum, which we check for, but which is impossible with the current unsigned variable type. Currently the if(len < 0) check is pointless. This patch fixes that. Signed-off-by: Joel Schopp <jschopp@austin.ibm.com> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
-rw-r--r--qemu-io.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/qemu-io.c b/qemu-io.c
index 7c6120b6a..2dbe20f33 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -135,7 +135,7 @@ create_iovec(QEMUIOVector *qiov, char **argv, int nr_iov, int pattern)
for (i = 0; i < nr_iov; i++) {
char *arg = argv[i];
- uint64_t len;
+ int64_t len;
len = cvtnum(arg);
if (len < 0) {
@@ -144,7 +144,7 @@ create_iovec(QEMUIOVector *qiov, char **argv, int nr_iov, int pattern)
}
/* should be SIZE_T_MAX, but that doesn't exist */
- if (len > UINT_MAX) {
+ if (len > INT_MAX) {
printf("too large length argument -- %s\n", arg);
goto fail;
}