diff options
| author | Alon Levy <alevy@redhat.com> | 2012-10-21 18:09:11 +0200 |
|---|---|---|
| committer | Alon Levy <alevy@redhat.com> | 2012-10-21 18:09:11 +0200 |
| commit | fa68ed7a501dbf6ea6e3ef433793355edffb3536 (patch) | |
| tree | 511844daadaa974a00237a06dde310b0278a7a25 | |
| parent | 4f2cac2efcce96199b033d5f5fcc559bcb6499d3 (diff) | |
qxl: remove redundant unlock (broke fb_do_work_items)
| -rw-r--r-- | drivers/gpu/drm/qxl/TODO | 7 | ||||
| -rw-r--r-- | drivers/gpu/drm/qxl/qxl_fb.c | 1 |
2 files changed, 6 insertions, 2 deletions
diff --git a/drivers/gpu/drm/qxl/TODO b/drivers/gpu/drm/qxl/TODO index f29c1e9ab5b..a6937ea9cf2 100644 --- a/drivers/gpu/drm/qxl/TODO +++ b/drivers/gpu/drm/qxl/TODO @@ -2,7 +2,7 @@ airlied: drop unmap ioctl, userspace can use munmap reorder qxl_drm_command, uint64_t together. implement our own gamma, used for fades. - no need to print a kernel git version, we have that in dmesg anyawys + no need to print a kernel git version, we have that in dmesg anyway. Allocation of on device memory in smaller chunks then PAGE_SIZE. For two users: @@ -40,3 +40,8 @@ Misc // destroying? and can anyone use an allocated but not mapped memory from userspace?? qxlfb_create_pinned_object - 1024x768 limit is actually used? + +============ +BROKEN STUFF +============ + diff --git a/drivers/gpu/drm/qxl/qxl_fb.c b/drivers/gpu/drm/qxl/qxl_fb.c index 85d79b1ba66..a4383787d3b 100644 --- a/drivers/gpu/drm/qxl/qxl_fb.c +++ b/drivers/gpu/drm/qxl/qxl_fb.c @@ -390,7 +390,6 @@ static void qxl_fb_do_work_items(struct qxl_device *qdev) spin_lock_irqsave(&qdev->fb_workqueue_spinlock, flags); list_del(&item->head); list_add_tail(&item->head, &qdev->fb_work_item_free); - spin_unlock_irqrestore(&qdev->fb_workqueue_spinlock, flags); } spin_unlock_irqrestore(&qdev->fb_workqueue_spinlock, flags); } |