Convert remaining sprintf calls to snprintf

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Mark Kettenis <kettenis@openbsd.org>

4 files changed, 11 insertions, 9 deletions

diff --git a/common.c b/common.c
index 3c59c0b..0492e47 100644
--- a/common.c
+++ b/common.c
@@ -217,7 +217,7 @@ SetUpConnectionSocket(int iport, void (*connectionFunc) (int))
 
 #ifdef USE_XTRANS
     ScopePort = iport - ServerBasePort;
-    sprintf(port, "%d", ScopePort);
+    snprintf(port, sizeof(port), "%d", ScopePort);
     if ((_X11TransMakeAllCOTSServerListeners(port, &partial, &ListenTransCount,
                                              &ListenTransConns) >= 0) &&
         (ListenTransCount >= 1)) {
diff --git a/fd.c b/fd.c
index 8b85460..45a7d77 100644
--- a/fd.c
+++ b/fd.c
@@ -311,7 +311,8 @@ MakeConnection(const char *server, short port, int report,
     /* determine the host machine for this process */
     if (*server == '\0') {
         sun.sun_family = AF_UNIX;
-        sprintf(sun.sun_path, "/tmp/.X11-unix/X%d", port - 6000);
+        snprintf(sun.sun_path, sizeof(sun.sun_path),
+                 "/tmp/.X11-unix/X%d", port - 6000);
         salen = sizeof(sun.sun_family) + strlen(sun.sun_path) + 1;
         saddr = (struct sockaddr *) &sun;
     }
@@ -335,8 +336,9 @@ MakeConnection(const char *server, short port, int report,
         if (port == ScopePort && strcmp(server, ScopeHost) == 0) {
             char error_message[100];
 
-            (void) sprintf(error_message, "Trying to attach to myself: %s,%d\n",
-                           server, sin.sin_port);
+            snprintf(error_message, sizeof(error_message),
+                     "Trying to attach to myself: %s,%d\n",
+                     server, sin.sin_port);
             panic(error_message);
         }
 
diff --git a/prtype.c b/prtype.c
index ef7889a..5c1f986 100644
--- a/prtype.c
+++ b/prtype.c
@@ -99,7 +99,7 @@ printrep(unsigned short c)
     }
     else {
         /* very large number -- print as 0xffff - 4 digit hex */
-        sprintf(pr, "0x%04x", c);
+        snprintf(pr, sizeof(pr), "0x%04x", c);
     }
     return (pr);
 }
@@ -1056,7 +1056,7 @@ DumpHexBuffer(const unsigned char *buf, long n)
         char h[6]; /* one hex or octal character */
 
         /* get the hex representations */
-        sprintf(h, "%02x", (0xff & buf[i]));
+        snprintf(h, sizeof(h), "%02x", (0xff & buf[i]));
 
         /* check if these characters will fit on this line */
         if ((column + strlen(h) + 1) > MAXline) {
diff --git a/scope.c b/scope.c
index ab3b805..f10648b 100644
--- a/scope.c
+++ b/scope.c
@@ -968,7 +968,7 @@ ClientName(FD fd)
 
     if (clientNumber <= 1)
         return ("");
-    (void) sprintf(name, " %d", FDinfo[fd].ClientNumber);
+    snprintf(name, sizeof(name), " %d", FDinfo[fd].ClientNumber);
     return (name);
 }
 
@@ -1215,8 +1215,8 @@ ConnectToServer(Boolean report)
     {
         char error_message[100];
 
-        sprintf(error_message, "Trying to attach to myself: %s,%d\n",
-                ServerHostName, port);
+        snprintf(error_message, sizeof(error_message),
+                 "Trying to attach to myself: %s,%d\n", ServerHostName, port);
         panic(error_message);
     }