Age | Commit message (Collapse) | Author | Files | Lines |
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Seen with GNU cpp, but not Solaris cpp:
./mdepend.cpp:128:27: error: invalid preprocessing directive #Flag
128 | # Flag to tell compiler to output dependencies directly
| ^~~~
./mdepend.cpp:129:27: error: invalid preprocessing directive #For
129 | # For example, with Sun compilers, -xM or -xM1 or
| ^~~
./mdepend.cpp:130:27: error: invalid preprocessing directive #with
130 | # with gcc, -M
| ^~~~
Reported-by: https://bugs.gentoo.org/919846
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Fixes warning from gcc 13 that is becoming an error in gcc 14
imake.c: In function ‘doit’:
imake.c:797:29: error: passing argument 2 of ‘execvp’ from incompatible
pointer type [-Werror=incompatible-pointer-types]
797 | execvp(cmd, argv);
| ^~~~
| |
| const char **
In file included from imake.c:172:
/usr/include/unistd.h:359:33: note: expected ‘char * const*’
but argument is of type ‘const char **’
359 | extern int execvp(const char *, char *const *);
| ^~~~~~~~~~~~~
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
To use this in your local repo clone, you will need to either run
`git blame --ignore-revs-file .git-blame-ignore-revs`
or set it permanently with
`git config blame.ignoreRevsFile .git-blame-ignore-revs`
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signal handlers have been required to have a void return, not int,
since C89. This #define hadn't been set in many years.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
imake.c: In function ‘FindImakefile’:
imake.c:662:27: warning: declaration of ‘Imakefile’ shadows a global declaration [-Wshadow]
FindImakefile(const char *Imakefile)
^~~~~~~~~
imake.c:319:13: note: shadowed declaration is here
const char *Imakefile = NULL;
^~~~~~~~~
imake.c: In function ‘define_os_defaults’:
imake.c:1636:9: warning: declaration of ‘name’ shadows a previous local [-Wshadow]
char name[PATH_MAX];
^~~~
imake.c:1430:18: note: shadowed declaration is here
struct utsname *name = NULL;
^~~~
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
imake.c: In function ‘ask_sun_compiler_for_versions’:
imake.c:1200:11: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
if (len < sizeof(cmdtorun)) {
^
imake.c: In function ‘get_gcc’:
imake.c:1380:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for (i = 0; i < sizeof (gcc_path) / sizeof gcc_path[0]; i++) {
^
imake.c: In function ‘writetmpfile’:
imake.c:2027:41: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
if (fwrite(buf, sizeof(char), cnt, fd) == -1)
^~
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent
fall-outs, when they contain space.
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Syncs the invocation of configure with the one from the server.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
configure.ac:130: warning: AC_OUTPUT should be used without arguments.
configure.ac:130: You should run autoupdate.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Found by using:
codespell --builtin clear,rare,usage,informal,code,names
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
https://bugs.freedesktop.org/show_bug.cgi?id=105136
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Mihail Konev <k.mvc@ya.ru>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
See http://people.gnome.org/~walters/docs/build-api.txt
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Julien Cristau <jcristau@debian.org>
|
|
Replicates Alan Coopersmith's fix for xinit.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=74031
Signed-off-by: Julien Cristau <jcristau@debian.org>
|
|
Fix build failure with -Werror=format-security:
imake.c:1008:5: error: format not a string literal and no format arguments [-Werror=format-security]
fprintf (inFile, command);
^
Signed-off-by: Julien Cristau <jcristau@debian.org>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
|
|
Regroup AC statements under the Autoconf initialization section.
Regroup AM statements under the Automake initialization section.
Add missing AC_CONFIG_SRCDIR
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Simply removing the definition lets the path found by configure be used,
seems to be the simplest way to handle the move from /usr/ccs/lib/cpp on
Solaris 10 and older to /usr/lib/cpp on Solaris 11 & later.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Another instance of the can-return-in-rare-cases nature of LogFatal()
raising red flags in static analysis.
Resolves warning from Parfait 1.0.1:
Error: File Leak
File Leak: Leaked File inFile
at line 1719 of imake.c in function 'cppit'.
inFile initialized at line 1699 with fopen
inFile leaks when inFile != NULL at line 1700
and fprintf(inFile, "%s\n", "/* imake - temporary file */") < 0 at line 1702.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Imake's LogFatal() checks if it's being re-entered and if so, returns,
so we can't mark it NORETURN, leading to static analyzers believing it
can return even in call paths it shouldn't.
Resolves warning from Parfait 1.0.1:
Error: File Invalid
File not Initialized: The value inFile is not initialized as a file.
at line 748 of imake.c in function 'CheckImakefileC'.
inFile initialized at line 738 with fopen(masterc, "r").
inFile destroyed at line 745 with fclose(inFile).
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Now that the log functions take variable arguments, don't need to pass
empty strings when there is no argument for the format string.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Allows use of printf attributes for checking format strings/arguments,
gets rid of LogFatalI wrapper just used for casting int to char *.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Performed with: find * -type f | xargs perl -i -p -e 's{[ \t]+$}{}'
git diff -w & git diff -b show no diffs from this change
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
"find: warning: you have specified the -depth option after a non-option
argument -type, but options are not positional (-depth affects tests
specified before it as well as those specified after it). Please specify
options before other arguments."
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Matthieu Herrb <matthieu.herrb@laas.fr>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Unrelated to the previous patches, the new value simply reflects
the reality that the minimum level for autoconf to configure
all x.org modules is 2.60 dated June 2006.
ftp://ftp.gnu.org/gnu/autoconf/autoconf-2.60.tar.gz
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
We no longer need to maintain compatibility with the monolith
Imakefile -D flags in the sources.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|