summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlan Coopersmith <alan.coopersmith@oracle.com>2023-10-08 09:41:30 -0700
committerAlan Coopersmith <alan.coopersmith@oracle.com>2023-10-08 09:41:30 -0700
commit7bed7727a86096a0f83a785a5a9a2ecad50507d9 (patch)
treec6a32366896bd05d1fca236343457b9566448cd7
parentfe0c5f29cdd80d8d2c42f7c21a7077b6d744df9f (diff)
Check for malloc failure in _xgeGetExtensionVersion
Handles gcc warning: Xge.c: In function ‘_xgeGetExtensionVersion’: Xge.c:196:25: warning: dereference of possibly-NULL ‘vers’ [CWE-690] [-Wanalyzer-possible-null-dereference] Fixes: 850263a ("Add GenericEvent extension (XGE).") Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-rw-r--r--src/Xge.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/src/Xge.c b/src/Xge.c
index 5a19408..4c4297f 100644
--- a/src/Xge.c
+++ b/src/Xge.c
@@ -192,8 +192,10 @@ _xgeGetExtensionVersion(Display* dpy,
}
vers = Xmalloc(sizeof(XGEVersionRec));
- vers->major_version = rep.majorVersion;
- vers->minor_version = rep.minorVersion;
+ if (vers != NULL) {
+ vers->major_version = rep.majorVersion;
+ vers->minor_version = rep.minorVersion;
+ }
return vers;
}