summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2024-03-02libXdmcp 1.1.5HEADlibXdmcp-1.1.5masterAlan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2023-09-23gitlab CI: add xz-utils to container for "make distcheck"Alan Coopersmith1-3/+3
Also update to latest ci-templates Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2023-09-23XdmcpWriteHeader: use calloc instead of malloc to alloc bufferAlan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2023-09-23XdmcpWriteHeader: drop unnecessary cast of free() argumentAlan Coopersmith1-1/+1
Clears clang complaint: Write.c:48:7: warning: cast from 'BYTE *' (aka 'unsigned char *') to 'unsigned long *' increases required alignment from 1 to 8 [-Wcast-align] free((unsigned long *)(buffer->data)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2023-09-23Clear -Wunused-macros warnings when arc4random_buf() is availableAlan Coopersmith1-5/+1
Reported by clang: Key.c:46:9: warning: macro is not used [-Wunused-macros] #define Time_t time_t ^ Key.c:52:9: warning: macro is not used [-Wunused-macros] #define random lrand48 ^ Key.c:51:9: warning: macro is not used [-Wunused-macros] #define srandom srand48 ^ Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2023-07-30Xdmcp.h: add access attributes to function prototypesAlan Coopersmith1-0/+45
May aid in static analysis by gcc Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2023-03-04configure: Use LT_INIT from libtool 2 instead of deprecated AC_PROG_LIBTOOLAlan Coopersmith1-3/+4
AC_PROG_LIBTOOL was replaced by LT_INIT in libtool 2 in 2008, so it's time to rely on it. Clears autoconf warnings: configure.ac:38: warning: The macro `AC_LIBTOOL_WIN32_DLL' is obsolete. configure.ac:38: You should run autoupdate. aclocal.m4:11889: AC_LIBTOOL_WIN32_DLL is expanded from... configure.ac:38: the top level configure.ac:38: warning: AC_LIBTOOL_WIN32_DLL: Remove this warning and the call to _LT_SET_OPTION when you configure.ac:38: put the 'win32-dll' option into LT_INIT's first parameter. ./lib/autoconf/general.m4:2434: AC_DIAGNOSE is expanded from... aclocal.m4:11889: AC_LIBTOOL_WIN32_DLL is expanded from... configure.ac:38: the top level configure.ac:39: warning: The macro `AC_PROG_LIBTOOL' is obsolete. configure.ac:39: You should run autoupdate. aclocal.m4:3465: AC_PROG_LIBTOOL is expanded from... configure.ac:39: the top level libtoolize: Consider adding 'AC_CONFIG_MACRO_DIRS([m4])' to configure.ac, libtoolize: and rerunning libtoolize and aclocal. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2023-02-25Remove "All rights reserved" from Oracle copyright noticesAlan Coopersmith1-1/+1
Oracle no longer includes this term in our copyright & license notices. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-11-18libXdmcp 1.1.4libXdmcp-1.1.4Alan Coopersmith1-2/+2
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-11-04Only link with libbsd if needed for arc4random_buf()Alan Coopersmith1-5/+11
Avoid unnecessary library dependency when using a libc with this function included Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-10-06Switch from libbsd to libbsd-overlayGuillem Jover2-5/+5
This is the preferred usage form for libbsd, as it makes the code more portable and requires no special includes for libbsd, by transparently injects the needed standard headers that would be used on a BSD. Signed-off-by: Guillem Jover <guillem@hadrons.org>
2022-08-06XdmcpDisposeARRAYofARRAY8: Reduce scope of iAlan Coopersmith1-3/+1
As suggested by cppcheck Also makes it unsigned to match array->length (a CARD8) Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-08-06arc4random_buf: Only declare ret if HAVE_GETENTROPY is definedAlan Coopersmith1-1/+1
Clears unused variable warning from cppcheck Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-08-06Use memcpy() instead of memmove() when buffers are known not to overlapAlan Coopersmith1-1/+1
This was introduced by a bcopy() -> memmove() substitution in 1993. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-07-17gitlab CI: enable doc builds in basic build testAlan Coopersmith1-9/+10
Also drops requirement for Signed-off-by in commit checks Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-07-17Fix spelling/wording issuesAlan Coopersmith5-10/+10
Found by using: codespell --builtin clear,rare,usage,informal,code,names Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-07-17Build xz tarballs instead of bzip2Alan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-02-23Fix build on Solaris 11.3.0 - 11.3.8Alan Coopersmith2-0/+8
Solaris 11.3.0 added getentropy() to libc and <sys/random.h> Solaris 11.3.9 added arc4random() to libc and <stdlib.h> Solaris 11.4.16 added getentropy() to <stdlib.h> So when building on Solaris releases from 11.3.0 to 11.3.8, libXdmcp would not find arc4random(), and thus fallback to using getentropy(), but was only looking for it in <stdlib.h>, resulting in a build error: Key.c: In function ‘arc4random_buf’: Key.c:86:5: error: implicit declaration of function ‘getentropy’ [-Werror=implicit-function-declaration] ret = getentropy (auth, len); ^ Reported-by: https://gnats.netbsd.org/cgi-bin/query-pr-single.pl?number=54628 Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-02-23gitlab CI: add a basic build testAlan Coopersmith1-0/+98
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2019-03-16Update configure.ac bug URL for gitlab migrationAlan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2019-03-16libXdmcp 1.1.3libXdmcp-1.1.3Alan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2018-11-19Update README for gitlab migrationAlan Coopersmith3-26/+19
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2017-05-05Fix compilation error when arc4random_buf is not availableBenjamin Tissoires1-4/+4
Not sure how I missed that, but I did. Also rename emulate_getrandom_buf() into insecure_getrandom_buf() as requested in the previous patch reviews. Last, getbits() expects an unsigned char, so remove the warning. Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2017-04-24Use getentropy() if arc4random_buf() is not availableBenjamin Tissoires2-6/+27
This allows to fix CVE-2017-2625 on Linux platforms without pulling in libbsd. The libc getentropy() is available since glibc 2.25 but also on OpenBSD. For Linux, we need at least a v3.17 kernel. If the recommended arc4random_buf() function is not available, emulate it by first trying to use getentropy() on a supported glibc and kernel. If the call fails, fall back to the current (vulnerable) code. Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com> Reviewed-by: Mark Kettenis <kettenis@openbsd.org> Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2017-01-26autogen: add default patch prefixMihail Konev1-0/+3
Signed-off-by: Mihail Konev <k.mvc@ya.ru>
2017-01-26autogen.sh: use quoted string variablesEmil Velikov1-4/+4
Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent fall-outs, when they contain space. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2017-01-26autogen.sh: use exec instead of waiting for configure to finishPeter Hutterer1-1/+1
Syncs the invocation of configure with the one from the server. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
2016-01-01do not use &fullrelvers; in xdmcp.xml (Debian bug 761628)Helmut Grohne1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2015-04-10Link with winsock library for socket functions on MinGWJon TURNEY1-0/+8
Signed-off-by: Jon TURNEY <jon.turney@dronecode.org.uk> Reviewed-by: David Macek <david.macek.0@gmail.com>
2015-03-21libXdmcp 1.1.2libXdmcp-1.1.2Alan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2015-01-19Add AC_USE_SYSTEM_EXTENSIONS to expose arc4random() interfaces in headersAlan Coopersmith1-0/+4
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2014-06-04autogen.sh: Honor NOCONFIGURE=1Alan Coopersmith1-1/+3
See http://people.gnome.org/~walters/docs/build-api.txt Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2014-06-04configure: Drop AM_MAINTAINER_MODEAlan Coopersmith2-2/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-08-15Also reject requests to allocate negative sized amounts of memoryAlan Coopersmith2-8/+12
Since the API is defined with size as a signed int, deal with it. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-08-15Ensure ARRAYofARRAY8 pointers are initialized to NULLAlan Coopersmith2-1/+44
Use calloc for the array of pointers to ensure pointers are cleared out so we don't try to free garbage if XdmcpDisposeARRAYofARRAY8 is called before the caller sets them to valid pointers. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-08-15Ensure ARRAY* structs are zero'ed out when oversize values are passedAlan Coopersmith1-28/+16
Previous fix missed a case in which we returned failure, but didn't fill in the data pointer & size values. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-08-15Add unit tests for Array allocation functionsAlan Coopersmith5-4/+84
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-08-11Use arc4random when available to produce the XDM-AUTHENTICATION1 keyMatthieu Herrb2-1/+12
arc4random() and associated functions can be found in libbsd on GNU/Linux systems. Signed-off-by: Matthieu Herrb <matthieu.herrb@laas.fr> Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-04-19Make XdmcpCopyARRAY8 call XdmcpAllocARRAY8 instead of replicating itAlan Coopersmith1-5/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-04-15Ensure ARRAY* structs are zero'ed out when allocation failsAlan Coopersmith1-7/+21
In the past some callers forgot to either initialize themselves or to check the return values, so could try to read or write to uninitialized pointers - we set the pointer to NULL & the size to 0 to avoid that. Reported-by: Ilja Van Sprundel <ivansprundel@ioactive.com> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2012-12-26Remove unused TLI ("STREAMSCONN") code from libXdmcpAlan Coopersmith3-40/+1
Has never been converted to build in modular builds, so has been unusable since X11R7.0 release in 2005. All known platforms with TLI/XTI support that X11R7 & later releases run on also have (and mostly prefer) BSD socket support for their networking API. Mostly performed via "unifdef -USTREAMSCONN", followed by manual cleanup. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2012-03-07libXdmcp 1.1.1libXdmcp-1.1.1Alan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2012-01-11informaltable cleanupMatt Dew1-284/+286
On certain tables, add top and bottom borders to table header and a bottom border to the table. This matches what those tables in the old pdfs looked like. the <?dbfo keep-together='always'> prevents tables from splitting across pages. Useful for tiny tables. Converting the colwidth to a floating point, IE, 1* -> 1.0* cleans up these build errors: WARNING: table-layout="fixed" and column-width unspecified => falling back to proportional-column-width(1) Signed-off-by: Matt Dew <marcoz@osource.org>
2011-10-04Cleanup IDs and links in docMatt Dew1-2/+2
1 - fix the capitalization of the ID attributes to match either the <title> or <funcdef> string it goes with. 2 - fix any <linkend>'s that were affected by 1. 3 - any <function> in the docs that has an actual funcdef, will become an olink. Signed-off-by: Matt Dew <marcoz@osource.org>
2011-09-16Strip trailing whitespaceAlan Coopersmith2-3/+3
Performed with: find * -type f | xargs perl -i -p -e 's{[ \t]+$}{}' git diff -w & git diff -b show no diffs from this change Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-09-15xdmcp: use appropriate markup for author affiliationGaetan Nadon1-5/+5
Docbook places the organization name above its divisions. Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2011-09-12docs: use the &fullrelvers; entity to set X11 release informationGaetan Nadon1-0/+2
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2011-09-11docs: remove <productnumber> which is not used by defaultGaetan Nadon1-1/+0
This element is not rendered by default on the title. A template customization is required to display it. X Window System does not have a product number. Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2011-09-08docbook.am: embed css styles inside the HTML HEAD elementGaetan Nadon1-2/+0
Rather than referring to the external xorg.css stylesheet, embed the content of the file in the html output produced. This is accomplished by using version 1.10 of xorg-xhtml.xsl. This makes the whole html docs tree much more relocatable. In addition, it eliminates xorg.css as a runtime file which makes xorg-sgml-doctools a build time only package. Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2011-09-07docbook.am: global maintenance update - entities, images and olinkingGaetan Nadon1-52/+62
Adding support in libX11 for html chunking caused a reorg of docbook.am as well as the xorg-sgml-doctools masterdb for olinking. The parameter img.src.path is added for pdf images. A searchpath to the root builddir is added for local entities, if present. The docbook.am makefile hides all the details and is identical for all 22 modules having DocBook documentation. It is included by a thin Makefile.am which requires no docbook knowledge. Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-14 08:09:44 +0000