Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Requires passing --with-xcb-errors to configure
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
xwininfo.c: In function ‘print_utf8’:
xwininfo.c:1914:26: warning: initialization discards ‘const’ qualifier
from pointer target type [-Wdiscarded-qualifiers]
ICONV_CONST char *inp = u8str;
^~~~~
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Reported by Oracle Parfait:
Error: Uninitialised memory
Uninitialised memory [uninitialised-mem] (CWE 456):
Possible access to uninitialised memory referenced by 'cookies'
at line 289 of dsimple.c in function 'recursive_Window_With_Name'.
called at line 420 in function 'Window_With_Name' with cookies = &cookies.
Path avoiding write at line 416
Write does not overlap at line 417
Write does not overlap at line 418
cookies allocated at line 410
cookies passed in at line 276 in function 'recursive_Window_With_Name'
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
dsimple.c: In function ‘recursive_Window_With_Name’:
dsimple.c:298:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
if ((namelen == prop_name_len) &&
^~
dsimple.c:336:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
if ((namelen == prop_name_len) &&
^~
dsimple.c:371:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for (i = 0; i < nchildren; i++) {
^
dsimple.c:380:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for (i = 0; i < nchildren; i++) {
^
dsimple.c:390:32: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for (/* keep previous i */; i < nchildren; i++) {
^
dsimple.c: In function ‘Get_Atom’:
dsimple.c:616:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
if (a->atom == -1) /* internal error */
^~
xwininfo.c: In function ‘wm_size_hints_reply’:
xwininfo.c:730:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
if (length > sizeof(wm_size_hints_t))
^
xwininfo.c: In function ‘Display_Event_Mask’:
xwininfo.c:1229:33: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for (bit=0, bit_mask=1; bit < sizeof(long)*8; bit++, bit_mask <<= 1)
^
xwininfo.c: In function ‘wm_hints_reply’:
xwininfo.c:1633:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
if (length > sizeof(wm_hints_t))
^
xwininfo.c: In function ‘is_valid_utf8’:
xwininfo.c:1843:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for (i = 0; i < len; i++) {
^
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
- Rename windows and display args.
- Mention of short (-d) -display option.
Signed-off-by: Stéphane Aulery <lkppo@free.fr>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
https://bugs.freedesktop.org/show_bug.cgi?id=72583
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Mihail Konev <k.mvc@ya.ru>
|
|
Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent
fall-outs, when they contain space.
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Syncs the invocation of configure with the one from the server.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
|
|
If the connection to the X server is lost while waiting for
the user to select a window interactively, xwininfo segfaults.
This is a regression introduced with the port to XCB, because
xcb_wait_for_event() can return NULL in case of an IO error and
xwininfo does not check for the actual returned value.
Signed-off-by: Olivier Fourdan <ofourdan@redhat.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
See http://people.gnome.org/~walters/docs/build-api.txt
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Not of the root window.
Signed-off-by: Pierre-Loup A. Griffais <pgriffais@nvidia.com>
Signed-off-by: Julien Cristau <jcristau@debian.org>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
|
|
Check number of screen entries before iterating past the end of the list
Reviewed-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Thomas Klausner <wiz@NetBSD.org>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
xwininfo.c:1886:15: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
if (inlen < 0) {
~~~~~ ^ ~
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
|
|
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
|
|
Add missing AC_CONFIG_SRCDIR([Makefile.am])
Move AC_USE_SYSTEM_EXTENSIONS higher up in Autoconf init section
which must come before XORG_DEFAULT_OPTIONS
Move XORG_DEFAULT_OPTIONS to its usual place with X.Org macros
Note that AC_FUNC_STRNLEN calls AC_REQUIRE(AC_USE_SYSTEM_EXTENSIONS)
Comment the strnlen function replacement.
http://pubs.opengroup.org/onlinepubs/9699919799/functions/strlen.html
No functional changes. Following the layout in
http://www.x.org/wiki/NewModuleGuidelines
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
AC_FUNC_STRLEN is one of the functions that call AC_LIBOBJ
which sets $LIBOBJ.
This reverts commit 3f3606b0e8de8f38f467126f07277e33a9285e53.
|
|
Starting at Autoconf 2.53, the use of LIBOBJS is an error.
http://www.gnu.org/software/autoconf/manual/autoconf.html#
AC_005fLIBOBJ-vs-LIBOBJS
There are no system functions to override in this module.
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
This allows the compiler to check the format against the argument types.
Signed-off-by: Guillem Jover <guillem@hadrons.org>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Guillem Jover <guillem@hadrons.org>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
This allows the compiler to check the format against the argument types.
Signed-off-by: Guillem Jover <guillem@hadrons.org>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Besides slightly reducing the binary size, this will be helpful when/if
i18n support is added to translate the strings.
Signed-off-by: Guillem Jover <guillem@hadrons.org>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Performed with: find * -type f | xargs perl -i -p -e 's{[ \t]+$}{}'
git diff -w & git diff -b show no diffs from this change
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
AC_SEARCH_LIBS does not detect GNU libiconv because its symbols are
exported in the "libiconv" namespace instead of "iconv". The AM_ICONV
macro correctly detects both glibc and GNU libiconv, defines HAVE_ICONV,
ICONV_CONST, and LIBICONV depending on the system. The config.rpath
file is required by this macro.
This adds a dependency on the aclocal macros from gettext (gettext-devel
in some distros) when building from git, but not when building from a
tarball.
Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
Reviewed-by: Gaetan Nadon <memsize@videotron.ca>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Changes all names to the xcb_icccm_* namespaced versions.
Requires xcb-icccm 0.3.8 (from new xcb-util-wm package) if used.
Still disabled by default, only enabled with --with-xcb-icccm
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Prevents strncmp returning on partial matches when one is shorter.
https://bugs.freedesktop.org/show_bug.cgi?id=37710
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Mark Kettenis <kettenis@openbsd.org>
|
|
Use services provided by XORG_MANPAGE_SECTIONS.
Use standard Makefile for man pages.
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
Using s/[ \t]*$//
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
This silences an Autoconf warning
|
|
In this case xcb_get_wm_name_reply() is not called, so reorganize the
code to not free a result which never was allocated.
Signed-off-by: Matthieu Herrb <matthieu.herrb@laas.fr>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|