summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2023-06-08Update xwininfo.man for #2HEADmaster積丹尼 Dan Jacobson1-0/+1
2023-04-09xwininfo 1.1.6xwininfo-1.1.6Alan Coopersmith2-3/+3
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2023-02-25Add option to use libxcb-errors to improve X protocol error messagesAlan Coopersmith4-100/+127
Requires passing --with-xcb-errors to configure Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-11-13Variable scope reduction as recommended by cppcheckAlan Coopersmith2-35/+38
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-11-13Silence -Wdiscarded-qualifiers warning on systems with non-const iconvAlan Coopersmith1-1/+1
xwininfo.c: In function ‘print_utf8’: xwininfo.c:1914:26: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] ICONV_CONST char *inp = u8str; ^~~~~ Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-11-13gitlab CI: stop requiring Signed-off-by in commitsAlan Coopersmith1-2/+2
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-04-10Window_With_Name(): make sure cookies.get_net_wm_name is setAlan Coopersmith1-0/+2
Reported by Oracle Parfait: Error: Uninitialised memory Uninitialised memory [uninitialised-mem] (CWE 456): Possible access to uninitialised memory referenced by 'cookies' at line 289 of dsimple.c in function 'recursive_Window_With_Name'. called at line 420 in function 'Window_With_Name' with cookies = &cookies. Path avoiding write at line 416 Write does not overlap at line 417 Write does not overlap at line 418 cookies allocated at line 410 cookies passed in at line 276 in function 'recursive_Window_With_Name' Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2021-12-07Build xz tarballs instead of bzip2Alan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2021-12-07gitlab CI: add a basic build testAlan Coopersmith1-0/+98
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2019-07-14xwininfo 1.1.5xwininfo-1.1.5Alan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2019-06-09Clear -Wsign-compare warnings from gcc 7.3Alan Coopersmith2-12/+13
dsimple.c: In function ‘recursive_Window_With_Name’: dsimple.c:298:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if ((namelen == prop_name_len) && ^~ dsimple.c:336:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if ((namelen == prop_name_len) && ^~ dsimple.c:371:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < nchildren; i++) { ^ dsimple.c:380:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < nchildren; i++) { ^ dsimple.c:390:32: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (/* keep previous i */; i < nchildren; i++) { ^ dsimple.c: In function ‘Get_Atom’: dsimple.c:616:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (a->atom == -1) /* internal error */ ^~ xwininfo.c: In function ‘wm_size_hints_reply’: xwininfo.c:730:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (length > sizeof(wm_size_hints_t)) ^ xwininfo.c: In function ‘Display_Event_Mask’: xwininfo.c:1229:33: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (bit=0, bit_mask=1; bit < sizeof(long)*8; bit++, bit_mask <<= 1) ^ xwininfo.c: In function ‘wm_hints_reply’: xwininfo.c:1633:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (length > sizeof(wm_hints_t)) ^ xwininfo.c: In function ‘is_valid_utf8’: xwininfo.c:1843:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < len; i++) { ^ Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2019-06-09Improve manpage and -h optionStéphane Aulery2-27/+27
- Rename windows and display args. - Mention of short (-d) -display option. Signed-off-by: Stéphane Aulery <lkppo@free.fr> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2018-11-21Update configure.ac bug URL for gitlab migrationAlan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2018-11-16Update README for gitlab migrationAlan Coopersmith3-27/+19
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2018-06-17In Find_Client, if (win == XCB_WINDOW_NONE), roots should be freed.David Hill1-1/+3
https://bugs.freedesktop.org/show_bug.cgi?id=72583 Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2018-03-09xwininfo 1.1.4xwininfo-1.1.4Alan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2017-01-26autogen: add default patch prefixMihail Konev1-0/+3
Signed-off-by: Mihail Konev <k.mvc@ya.ru>
2017-01-26autogen.sh: use quoted string variablesEmil Velikov1-4/+4
Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent fall-outs, when they contain space. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2017-01-26autogen.sh: use exec instead of waiting for configure to finishPeter Hutterer1-1/+1
Syncs the invocation of configure with the one from the server. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
2015-01-07xwininfo: do not segfault on IO errorOlivier Fourdan1-0/+2
If the connection to the X server is lost while waiting for the user to select a window interactively, xwininfo segfaults. This is a regression introduced with the port to XCB, because xcb_wait_for_event() can return NULL in case of an IO error and xwininfo does not check for the actual returned value. Signed-off-by: Olivier Fourdan <ofourdan@redhat.com> Reviewed-by: Adam Jackson <ajax@redhat.com> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2014-06-03Add -version option to print program versionAlan Coopersmith2-1/+12
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2014-06-03Print which option was in error along with usage messageAlan Coopersmith3-3/+5
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2014-06-03autogen.sh: Honor NOCONFIGURE=1Alan Coopersmith1-2/+3
See http://people.gnome.org/~walters/docs/build-api.txt Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2014-06-03configure: Drop AM_MAINTAINER_MODEAlan Coopersmith2-2/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-05-17xwininfo 1.1.3xwininfo-1.1.3Alan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-01-12Quiet some clang warnings about implicit int <-> size_t conversionsAlan Coopersmith1-2/+2
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2012-10-10xwininfo: report the Visual class of the selected WindowPierre-Loup A. Griffais1-1/+1
Not of the root window. Signed-off-by: Pierre-Loup A. Griffais <pgriffais@nvidia.com> Signed-off-by: Julien Cristau <jcristau@debian.org>
2012-08-29Print more detailed error messages when xcb_connect failsAlan Coopersmith1-4/+17
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
2012-08-29Bug 53242 - xwininfo segfaults on invalid screenDavid Venz1-0/+6
Check number of screen entries before iterating past the end of the list Reviewed-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com> Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2012-08-25Get rid of a number of warnings.Thomas Klausner1-19/+19
Signed-off-by: Thomas Klausner <wiz@NetBSD.org> Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2012-08-25Remove dead code (size_t is always >= 0)Jeremy Huddleston Sequoia1-4/+0
xwininfo.c:1886:15: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare] if (inlen < 0) { ~~~~~ ^ ~ Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
2012-08-25Declare usage() as _X_NORETURNJeremy Huddleston Sequoia1-0/+1
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
2012-01-25configure.ac: regroup statements and commentGaetan Nadon1-10/+11
Add missing AC_CONFIG_SRCDIR([Makefile.am]) Move AC_USE_SYSTEM_EXTENSIONS higher up in Autoconf init section which must come before XORG_DEFAULT_OPTIONS Move XORG_DEFAULT_OPTIONS to its usual place with X.Org macros Note that AC_FUNC_STRNLEN calls AC_REQUIRE(AC_USE_SYSTEM_EXTENSIONS) Comment the strnlen function replacement. http://pubs.opengroup.org/onlinepubs/9699919799/functions/strlen.html No functional changes. Following the layout in http://www.x.org/wiki/NewModuleGuidelines Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2012-01-20Revert "make: remove $(LIBOBJS) dead code"Gaetan Nadon1-1/+1
AC_FUNC_STRLEN is one of the functions that call AC_LIBOBJ which sets $LIBOBJ. This reverts commit 3f3606b0e8de8f38f467126f07277e33a9285e53.
2012-01-20make: remove $(LIBOBJS) dead codeGaetan Nadon1-1/+1
Starting at Autoconf 2.53, the use of LIBOBJS is an error. http://www.gnu.org/software/autoconf/manual/autoconf.html# AC_005fLIBOBJ-vs-LIBOBJS There are no system functions to override in this module. Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2011-10-06Use format string literals instead of variables to print atom namesGuillem Jover1-21/+20
This allows the compiler to check the format against the argument types. Signed-off-by: Guillem Jover <guillem@hadrons.org> Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-10-06Refactor atom name printing into a new Display_Atom_Name functionGuillem Jover1-22/+16
Signed-off-by: Guillem Jover <guillem@hadrons.org> Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-10-06Use format string literals instead of variables to print window idsGuillem Jover1-7/+17
This allows the compiler to check the format against the argument types. Signed-off-by: Guillem Jover <guillem@hadrons.org> Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-10-06Move leading ": " out from buffer to the error string printerGuillem Jover1-19/+19
Besides slightly reducing the binary size, this will be helpful when/if i18n support is added to translate the strings. Signed-off-by: Guillem Jover <guillem@hadrons.org> Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-09-28Add const attributes to fix gcc -Wwrite-strings warningsAlan Coopersmith2-4/+4
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-09-28Strip trailing whitespaceAlan Coopersmith2-5/+5
Performed with: find * -type f | xargs perl -i -p -e 's{[ \t]+$}{}' git diff -w & git diff -b show no diffs from this change Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-08-24Use AM_ICONVYaakov Selkowitz3-4/+693
AC_SEARCH_LIBS does not detect GNU libiconv because its symbols are exported in the "libiconv" namespace instead of "iconv". The AM_ICONV macro correctly detects both glibc and GNU libiconv, defines HAVE_ICONV, ICONV_CONST, and LIBICONV depending on the system. The config.rpath file is required by this macro. This adds a dependency on the aclocal macros from gettext (gettext-devel in some distros) when building from git, but not when building from a tarball. Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net> Reviewed-by: Gaetan Nadon <memsize@videotron.ca>
2011-06-29xwininfo 1.1.2xwininfo-1.1.2Alan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-06-18Update to xcb-icccm 0.3.8 APIAlan Coopersmith3-86/+88
Changes all names to the xcb_icccm_* namespaced versions. Requires xcb-icccm 0.3.8 (from new xcb-util-wm package) if used. Still disabled by default, only enabled with --with-xcb-icccm Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-06-08When matching window names, ensure name lengths match tooAlan Coopersmith1-6/+10
Prevents strncmp returning on partial matches when one is shorter. https://bugs.freedesktop.org/show_bug.cgi?id=37710 Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Mark Kettenis <kettenis@openbsd.org>
2011-01-19config: move man pages into their own directoryGaetan Nadon4-17/+18
Use services provided by XORG_MANPAGE_SECTIONS. Use standard Makefile for man pages. Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2011-01-13man: remove trailing spaces and tabsGaetan Nadon1-11/+11
Using s/[ \t]*$// Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2011-01-12config: replace deprecated AM_CONFIG_HEADER with AC_CONFIG_HEADERSGaetan Nadon1-1/+1
This silences an Autoconf warning
2011-01-09Fix for invalid free if window has a _NET_WM_NAME property.Tim van der Molen1-7/+3
In this case xcb_get_wm_name_reply() is not called, so reorganize the code to not free a result which never was allocated. Signed-off-by: Matthieu Herrb <matthieu.herrb@laas.fr> Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-01-07xwininfo.c:282: warning: no previous prototype for 'usage'Alan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>