diff options
author | Jeremy Huddleston <jeremyhu@apple.com> | 2011-05-07 21:41:13 -0700 |
---|---|---|
committer | Jeremy Huddleston <jeremyhu@apple.com> | 2011-05-07 21:41:13 -0700 |
commit | e3092ad9d9742630aa34044c7a37802ccfc6ee61 (patch) | |
tree | 2dcc4318fe2e52364ef4290937d10060d63a193a /LED.c | |
parent | 01ee88f0c5e66bde5fed99c520e3bdc679740b96 (diff) |
Fix typo in SetValues which could fail to detect a change if only width/height changed
LED.c:249:25: warning: Both operands to '!=' always have the same value
|| curlw->core.height != curlw->core.height) {
~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~
LED.c:248:24: warning: Both operands to '!=' always have the same value
|| curlw->core.width != curlw->core.width
~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~
Found-by: clang static analyzer
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
Diffstat (limited to 'LED.c')
-rw-r--r-- | LED.c | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -245,8 +245,8 @@ SetValues(Widget current, Widget request, Widget new, || curlw->core.background_pixel != newlw->core.background_pixel || curlw->led.on_color != newlw->led.on_color || curlw->led.off_color != newlw->led.off_color - || curlw->core.width != curlw->core.width - || curlw->core.height != curlw->core.height) { + || curlw->core.width != newlw->core.width + || curlw->core.height != newlw->core.height) { GetPixmaps(newlw); changed= TRUE; } |