summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlan Coopersmith <alan.coopersmith@oracle.com>2013-12-08 13:08:40 -0800
committerAlan Coopersmith <alan.coopersmith@oracle.com>2013-12-09 21:32:33 -0800
commit05757e21b7b51d1f59137693f051b19742d28072 (patch)
tree54134a538aa15cf9865ccec8545ea1a49e6c76dd
parent34efe0c4ec0d0e93e044448baabbdaa6d46e7415 (diff)
XkbQueryExtension returns a Bool, don't use > 0 to check it
We just want to know if XkbQueryExtension returned false, so ! is enough, don't need > 0 as well. Reported by cppcheck: [app/xkbutils/xkbbell.c:205]: (warning) Comparison of a boolean value using relational operator (<, >, <= or >=). Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
-rw-r--r--xkbbell.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/xkbbell.c b/xkbbell.c
index ac06b35..95b8604 100644
--- a/xkbbell.c
+++ b/xkbbell.c
@@ -202,7 +202,7 @@ main(int argc, char *argv[])
XkbMajorVersion, XkbMinorVersion);
fprintf(stderr, " Trying anyway\n");
}
- if (!XkbQueryExtension(dpy, &i1, &i2, &i3, &i4, &i5) > 0) {
+ if (!XkbQueryExtension(dpy, &i1, &i2, &i3, &i4, &i5)) {
if ((i4 != 0) || (i5 != 0))
fprintf(stderr,
"server supports incompatible XKB version %d.%02d\n", i4,