summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlan Coopersmith <alan.coopersmith@oracle.com>2022-09-11 15:27:47 -0700
committerAlan Coopersmith <alan.coopersmith@oracle.com>2022-09-11 15:30:04 -0700
commit2f80557c9dfbf8c5ef8eceee54a5a346d89400ee (patch)
tree65242b3b17cd61450b52d870a10ef0d7151fbb02
parentbac7165659d728deb0f32ec7d81171bb2f1162b3 (diff)
Variable scope reductions as recommended by cppcheck
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-rw-r--r--xfsinfo.c20
1 files changed, 7 insertions, 13 deletions
diff --git a/xfsinfo.c b/xfsinfo.c
index 9ed847d..5a00928 100644
--- a/xfsinfo.c
+++ b/xfsinfo.c
@@ -84,11 +84,10 @@ main(int argc, char *argv[])
{
FSServer *svr;
char *servername = NULL;
- int i;
progname = argv[0];
- for (i = 1; i < argc; i++) {
+ for (int i = 1; i < argc; i++) {
if (strncmp(argv[i], "-s", 2) == 0) {
if (++i >= argc) {
fprintf (stderr, "%s: %s requires an argument\n",
@@ -159,9 +158,7 @@ print_catalogue_info(FSServer *svr)
printf("number of catalogues: %d\n", n);
if (cats) {
- int i;
-
- for (i = 0; i < n; i++) {
+ for (int i = 0; i < n; i++) {
printf(" %s\n", cats[i]);
}
FSFreeCatalogues(cats);
@@ -176,9 +173,7 @@ print_extension_info(FSServer *svr)
printf("number of extensions: %d\n", n);
if (extlist) {
- int i;
-
- for (i = 0; i < n; i++) {
+ for (int i = 0; i < n; i++) {
printf(" %s\n", extlist[i]);
}
FSFreeExtensionList(extlist);
@@ -188,15 +183,14 @@ print_extension_info(FSServer *svr)
static void
print_alternate_info(FSServer *svr)
{
- AlternateServer *alts;
- int i,
- num;
+ int num;
num = FSNumAlternateServers(svr);
printf("Number of alternate servers: %d\n", num);
if (num) {
- alts = FSAlternateServers(svr);
- for (i = 0; i < num; i++) {
+ AlternateServer *alts = FSAlternateServers(svr);
+
+ for (int i = 0; i < num; i++) {
printf(" #%1d\t%s%s\n", i, alts[i].name,
(alts[i].subset) ? "(subset)" : "");
}