Fix a possible NULL dereference in an error handler

save.c:255:10: warning: Array access (via field 'wm_command') results in a null pointer dereference
            if (entry->wm_command[i])
                ^      ~~~~~~~~~~
1 warning generated.

Found-by: clang static analyzer
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>

1 files changed, 9 insertions, 7 deletions

diff --git a/save.c b/save.c
index 4bf3663..0f71fd1 100644
--- a/save.c
+++ b/save.c
@@ -249,15 +249,17 @@ give_up:
 	free (entry->class.res_class);
     if (entry->wm_name)
 	free (entry->wm_name);
-    if (entry->wm_command_count)
-    {
-	for (i = 0; i < entry->wm_command_count; i++)
-	    if (entry->wm_command[i])
-		free (entry->wm_command[i]);
-    }
     if (entry->wm_command)
+    {
+        if (entry->wm_command_count)
+        {
+	    for (i = 0; i < entry->wm_command_count; i++)
+	        if (entry->wm_command[i])
+		    free (entry->wm_command[i]);
+        }
 	free ((char *) entry->wm_command);
-    
+    }
+
     free ((char *) entry);
     *pentry = NULL;