Replace last strcpy call + manual append with snprintf call

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

1 files changed, 3 insertions, 5 deletions

diff --git a/config.c b/config.c
index e11b855..8696ac5 100644
--- a/config.c
+++ b/config.c
@@ -158,17 +158,15 @@ GetConfig (
 
 	if (*managed)
 	{
-	    n = strlen (p);
-	    *startCommand = (char *) malloc (n + 2);
+	    n = strlen (p) + 2;
+	    *startCommand = (char *) malloc (n);
 	    if (! *startCommand) {
 		fprintf (stderr,
 			 "Memory allocation failed for service \"%s\"\n",
 			 serviceName);
 		break;
 	    }
-	    strcpy (*startCommand, p);
-	    (*startCommand)[n] = '&';
-	    (*startCommand)[n + 1] = '\0';
+	    snprintf(*startCommand, n, "%s&", p);
 	}
 	else
 	{