summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNakshtra Goyal <nakshtra.goyal@intel.com>2024-04-12 15:55:45 +0530
committerJanga Rahul Kumar <janga.rahul.kumar@intel.com>2024-04-17 13:56:01 +0530
commit189483744e9ff56ea573e07a049c5365404c7ecb (patch)
treeddff695fd9c5236be41ff3e8dfe2c727b7637aae
parent3a71f659700859cab49b8e05a198ba18a5cbd24a (diff)
tests/intel/xe_sysfs_defaults: Validate for all default values
Change in igt_assert_f function parameters so that it also validate for property value equals to 0. v2: use uint64_t for property_value,use bool __igt_sysfs_get_u64 in igt_assert_f(Kamil) v3: correcting format type for property value in igt_debug in test_defaults function for uint64_t type(Kamil) Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com> Cc: Janga Rahul Kumar <janga.rahul.kumar@intel.com> Cc: Priyanka Dandamudi <priyanka.dandamudi@intel.com> Cc: Kamil Konieczny <kamil.konieczny@intel.com> Signed-off-by: Nakshtra Goyal <nakshtra.goyal@intel.com> Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com> Reviewed-by: Janga Rahul Kumar <janga.rahul.kumar@intel.com> Reviewed-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
-rw-r--r--tests/intel/xe_sysfs_defaults.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/tests/intel/xe_sysfs_defaults.c b/tests/intel/xe_sysfs_defaults.c
index b1ab36589..fd7dea77b 100644
--- a/tests/intel/xe_sysfs_defaults.c
+++ b/tests/intel/xe_sysfs_defaults.c
@@ -28,7 +28,7 @@
static void test_defaults(int xe, int engine, const char **property)
{
struct dirent *de;
- int property_value;
+ uint64_t property_value;
int defaults;
DIR *dir;
@@ -42,10 +42,10 @@ static void test_defaults(int xe, int engine, const char **property)
igt_debug("Checking attr '%s'\n", de->d_name);
- igt_assert_f(property_value = igt_sysfs_get_u64(defaults, de->d_name),
+ igt_assert_f(__igt_sysfs_get_u64(defaults, de->d_name, &property_value),
"Default value %s is not present!\n", de->d_name);
- igt_debug("Default property:%s, value:%d\n", de->d_name, property_value);
+ igt_debug("Default property:%s, value:0x%" PRId64 "\n", de->d_name, property_value);
igt_assert_f(!igt_sysfs_set(defaults, de->d_name, "garbage"),
"write into default value of %s succeeded!\n",