Fix -Wsign-compare warnings

actions.c:291:21: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
    for ( i = 0 ; i < num_table; i++ )
                  ~ ^ ~~~~~~~~~
actions.c:299:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
    for (i = 0; i < num_table; ) {
                ~ ^ ~~~~~~~~~
actions.c:302:8: warning: comparison of integers of different signs: 'int' and 'unsigned int' [-Wsign-compare]
        if (i == (num_table - 1))
            ~ ^   ~~~~~~~~~~~~~
actions.c:304:13: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
        else if (i < num_table)
                 ~ ^ ~~~~~~~~~

geometry.c:150:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
    for (i = 0; i < tree_info->num_nodes; i++)
                ~ ^ ~~~~~~~~~~~~~~~~~~~~
geometry.c:380:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
    for (i = 0; i < tree_info->num_flash_widgets; i++) {
                ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
geometry.c:401:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
    for (i = 0; i < tree_info->num_flash_widgets; i++)
                ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
geometry.c:423:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
    for (i = 0; i < tree_info->num_flash_widgets; i++)
                ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
geometry.c:428:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
    for (i = 0; i < tree_info->num_flash_widgets; i++)
                ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~

handler.c:475:13: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
    if (len > malloc_size) {
        ~~~ ^ ~~~~~~~~~~~
handler.c:476:58: warning: implicit conversion changes signedness: 'int' to 'unsigned long' [-Wsign-conversion]
        malloc_string = XtRealloc(malloc_string, sizeof(char) * len);
                                                              ~ ^~~
handler.c:477:16: warning: implicit conversion changes signedness: 'int' to 'Cardinal' (aka 'unsigned int') [-Wsign-conversion]
        malloc_size = len;
                    ~ ^~~

utils.c:167:37: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
    for (node = top_node, i = 1 ; i < number; i++) {
                                  ~ ^ ~~~~~~
utils.c:170:16: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
        for (j = 0; j < node->num_children; j++) {
                    ~ ^ ~~~~~~~~~~~~~~~~~~
utils.c:215:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
    for (i = 0; i < node->num_children; i++) {
                ~ ^ ~~~~~~~~~~~~~~~~~~
utils.c:787:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
    for (i = 0; i < top_node->num_children; i++)
                ~ ^ ~~~~~~~~~~~~~~~~~~~~~~

wtree.c:129:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
    for (i = 0; i < top->num_children; i++)
                ~ ^ ~~~~~~~~~~~~~~~~~
wtree.c:194:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
    for (i = 0; i < info->num_nodes; i++) {
                ~ ^ ~~~~~~~~~~~~~~~
wtree.c:216:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
    for (i = 0; i < info->num_nodes; i++)
                ~ ^ ~~~~~~~~~~~~~~~
wtree.c:270:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
    for (i = 0; i < top->num_children; i++)
                ~ ^ ~~~~~~~~~~~~~~~~~
wtree.c:339:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
    for (i = 0; i < num_active_nodes; i++)
                ~ ^ ~~~~~~~~~~~~~~~~
wtree.c:386:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
    for (i = 0; i < node->num_children; i++)
                ~ ^ ~~~~~~~~~~~~~~~~~~
wtree.c:446:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
    for (i = 0; i < node->num_children; i++)
                ~ ^ ~~~~~~~~~~~~~~~~~~
wtree.c:478:16: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
        for (i = 0; i < node->num_children; i++) {
                    ~ ^ ~~~~~~~~~~~~~~~~~~
wtree.c:607:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
    for (i = 0; i < tree_info->num_nodes; i++)
                ~ ^ ~~~~~~~~~~~~~~~~~~~~
wtree.c:686:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
    for (i = 0; i < node->num_children; i++)
                ~ ^ ~~~~~~~~~~~~~~~~~~

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

1 files changed, 4 insertions, 4 deletions

diff --git a/geometry.c b/geometry.c
index 0bc9445..c9b01a5 100644
--- a/geometry.c
+++ b/geometry.c
@@ -127,7 +127,7 @@ DisplayChild(Event *event)
 void
 _FlashActiveWidgets(TreeInfo *tree_info)
 {
-    int i;
+    Cardinal i;
     ProtocolStream * stream = &(global_client.stream);
 
     if (tree_info == NULL) {
@@ -374,7 +374,7 @@ static void
 FlashWidgetsOn(XtPointer info_ptr, XtIntervalId *id)
 {
 
-    int i;
+    Cardinal i;
     TreeInfo * tree_info = (TreeInfo *) info_ptr;
     
     for (i = 0; i < tree_info->num_flash_widgets; i++) {
@@ -395,7 +395,7 @@ FlashWidgetsOn(XtPointer info_ptr, XtIntervalId *id)
 static void
 FlashWidgetsOff(XtPointer info_ptr, XtIntervalId *id)
 {
-    int i;
+    Cardinal i;
     TreeInfo * tree_info = (TreeInfo *) info_ptr;
     
     for (i = 0; i < tree_info->num_flash_widgets; i++)
@@ -413,7 +413,7 @@ FlashWidgetsOff(XtPointer info_ptr, XtIntervalId *id)
 static void
 FlashWidgetsCleanup(XtPointer info_ptr, XtIntervalId *id)
 {
-    int i;
+    Cardinal i;
     TreeInfo * tree_info = (TreeInfo *) info_ptr;
 
 /*