diff options
| author | Peter Hutterer <peter.hutterer@who-t.net> | 2023-12-20 14:38:46 +1000 |
|---|---|---|
| committer | Peter Hutterer <peter.hutterer@who-t.net> | 2024-01-07 23:01:45 +0000 |
| commit | 4481eb0f0022ba7c7208e855554548a1a7850fb4 (patch) | |
| tree | cbd25de7a10391d399548417d1b93da013377946 | |
| parent | 7baca6a9347b7a620d936eab38c5d8e53d4ec195 (diff) | |
tests: fix a few python deprecation warnings
DeprecationWarning: Testing an element's truth value will raise an exception in future versions.
Use specific 'len(elem)' or 'elem is not None' test instead.
| -rw-r--r-- | tests/test_rules_xml.py | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/tests/test_rules_xml.py b/tests/test_rules_xml.py index 1bf68699..cd0df4f8 100644 --- a/tests/test_rules_xml.py +++ b/tests/test_rules_xml.py @@ -85,8 +85,8 @@ class Layout: def __init__(self, rulesfile, layout, variant=None): self.rulesfile = rulesfile self.layout = ConfigItem.from_elem(layout) - self.variant = ConfigItem.from_elem(variant) if variant else None - if variant: + self.variant = ConfigItem.from_elem(variant) if variant is not None else None + if variant is not None: self.name = f"{self.layout.name}({self.variant.name})" else: self.name = f"{self.layout.name}" @@ -166,11 +166,11 @@ class ConfigItem: ci.popularity = ci_element.attrib.get("popularity") langlist = cls._fetch_subelement(ci_element, "languageList") - if langlist: + if langlist is not None: ci.iso639 = cls._fetch_subelement_text(langlist, "iso639Id") countrylist = cls._fetch_subelement(ci_element, "countryList") - if countrylist: + if countrylist is not None: ci.iso3166 = cls._fetch_subelement_text(countrylist, "iso3166Id") return ci |