1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
|
All patches to Telepathy components are reviewed by (hopefully) more experienced developers of the components to ensure that they meet standards of code quality, understandability and maintainability.
# Procedure
* Record your changes in a Git branch. See [[Git|Git]] for details on how to get started.
* Publish your branch online somewhere; we suggest [[requesting a freedesktop.org account|http://wiki.freedesktop.org/wiki/AccountRequests]], or you can use your own webspace or any public git hosting site (gitorious, github etc.).
* Ping one of the reviewers listed below with your branch URL, on IRC, by e-mail to the mailing list, or in a bug with the 'patch' keyword (using a bug is recommended for complex patches or if we don't respond to IRC pings). The reviewer may ask you some questions and ask you to make some changes to your patch.
* When they approve it, you can commit it if you have access, or the reviewer may commit it for you.
# Reviewers
The maintainer is responsible for making or delegating releases, and decides who can be a reviewer. Most reviewers can be found on #telepathy.
When reviewing, please pay attention to [[Style] and [[Portability|Style] and [[Portability]].
To review a patch in a bug, comment on it, and then in the whiteboard mark review+ or review-
[[All fd.o Telepathy bugs with patches|http://bugs.freedesktop.org/buglist.cgi?query_format=advanced&product=Telepathy&keywords_type=allwords&keywords=patch&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED]]
[[!table header="no" class="mointable" data="""
**Module** | **Maintainer** | **Other reviewers** | **Bugzilla review queue**
empathy | cassidy | Zdra, danni, sjoerd, jonnylamb, Cosimoc | [[Empathy patch report|https://bugzilla.gnome.org/page.cgi?id=patchreport.html&product=empathy&patch-status=none]]
papyon | lfrb | [[KaKaRoTo|KaKaRoTo]], istaz | [[papyon bugs with patches|http://bugs.freedesktop.org/buglist.cgi?query_format=advanced&product=Telepathy&component=papyon&keywords_type=allwords&keywords=patch&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED]]
telepathy-butterfly | jonnylamb | istaz | [[butterfly bugs with patches|http://bugs.freedesktop.org/buglist.cgi?query_format=advanced&product=Telepathy&component=butterfly&keywords_type=allwords&keywords=patch&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED]]
telepathy-doc | danni | ... |
telepathy-farsight
telepathy-farstream | ocrete | ... |
telepathy-gabble | smcv | Robot101, cassidy, wjt, ptlo, daf | [[gabble bugs with patches|http://bugs.freedesktop.org/buglist.cgi?query_format=advanced&product=Telepathy&component=gabble&keywords_type=allwords&keywords=patch&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED]]
telepathy-glib | smcv | Robot101, wjt, ... | [[tpglib bugs with patches|http://bugs.freedesktop.org/buglist.cgi?query_format=advanced&product=Telepathy&component=tp-glib&keywords_type=allwords&keywords=patch&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED]]
telepathy-haze | wjt | jonnylamb, smcv (when he's not busy with all his other components), Robot101 (when he's feeling masochistic), Maiku |
telepathy-idle | wjt | oggis, sjoerd, jonnylamb, smcv |
telepathy-inspector | smcv | sjoerd |
telepathy-logger | stormer | pochu, danni | [[Logger's bugs with patches|http://bugs.freedesktop.org/buglist.cgi?query_format=advanced&product=Telepathy&component=logger&keywords_type=allwords&keywords=patch&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED]]
telepathy-mission-control | smcv | mardy, ... |
telepathy-pinnochio | treitter | ... |
telepathy-python | cassidy | jonnylamb |
telepathy-qt4 | smcv | andrunko, oggis | [[tpqt4 bugs with patches|http://bugs.freedesktop.org/buglist.cgi?query_format=advanced&product=Telepathy&component=tp-qt4&keywords_type=allwords&keywords=patch&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED]]
telepathy-salut | sjoerd | ... |
telepathy-sofiasip | mikhailz | ptlo |
telepathy-spec | Robot101/smcv | the telepathy-spec cabal¹ | [[spec bugs with patches|http://bugs.freedesktop.org/buglist.cgi?query_format=advanced&product=Telepathy&component=tp-spec&keywords_type=allwords&keywords=patch&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED]]
tictactube | epmf | (none) |
"""]]
### Notes
1. substantial telepathy-spec changes should usually be discussed by several component maintainers
|
