summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlexander Akulich <akulichalexander@gmail.com>2019-11-07 02:25:11 +0300
committerAlexander Akulich <akulichalexander@gmail.com>2019-11-08 02:03:55 +0300
commit8d129b4d973498c97456192135c8cddf17b17ee5 (patch)
tree58e9b49d6d373774d5e3d1427803bc5adf05d7a4
parent148f88dcf49577b9518ee7c8ad6c65c2c10e7ea8 (diff)
CMake: Properly set visibility for the linked libraries
-rw-r--r--TelepathyQt/CMakeLists.txt20
1 files changed, 11 insertions, 9 deletions
diff --git a/TelepathyQt/CMakeLists.txt b/TelepathyQt/CMakeLists.txt
index f79d3d6c..4a0fe38c 100644
--- a/TelepathyQt/CMakeLists.txt
+++ b/TelepathyQt/CMakeLists.txt
@@ -769,32 +769,35 @@ foreach(moc_src ${telepathy_qt_MOC_SRCS})
endforeach()
# Link
-target_link_libraries(telepathy-qt${QT_VERSION_MAJOR} # PUBLIC
+target_link_libraries(telepathy-qt${QT_VERSION_MAJOR} PUBLIC
Qt5::Core
Qt5::DBus
Qt5::Network
+)
+
+target_link_libraries(telepathy-qt${QT_VERSION_MAJOR} PRIVATE
Qt5::Xml
)
-target_link_libraries(telepathy-qt${QT_VERSION_MAJOR}
+target_link_libraries(telepathy-qt${QT_VERSION_MAJOR} PUBLIC
${TP_QT_LIBRARY_LINKER_FLAGS})
target_include_directories(telepathy-qt${QT_VERSION_MAJOR} PUBLIC "$<INSTALL_INTERFACE:${INCLUDE_INSTALL_DIR}/telepathy-qt${QT_VERSION_MAJOR}/>")
# Link - Library used by tests to test some unexported functionality
-target_link_libraries(telepathy-qt-test-backdoors # PUBLIC
+target_link_libraries(telepathy-qt-test-backdoors PUBLIC
Qt5::Core
Qt5::DBus
Qt5::Network
Qt5::Xml
)
-target_link_libraries(telepathy-qt-test-backdoors
+target_link_libraries(telepathy-qt-test-backdoors PUBLIC
${TP_QT_LIBRARY_LINKER_FLAGS})
if (ENABLE_COMPILER_COVERAGE)
- target_link_libraries(telepathy-qt${QT_VERSION_MAJOR} gcov)
- target_link_libraries(telepathy-qt-test-backdoors gcov)
+ target_link_libraries(telepathy-qt${QT_VERSION_MAJOR} PRIVATE gcov)
+ target_link_libraries(telepathy-qt-test-backdoors PRIVATE gcov)
endif ()
# Set the correct version number
@@ -981,11 +984,10 @@ if(ENABLE_SERVICE_SUPPORT)
endforeach()
# Link
- target_link_libraries(telepathy-qt${QT_VERSION_MAJOR}-service
+ target_link_libraries(telepathy-qt${QT_VERSION_MAJOR}-service PUBLIC
Qt5::Core
Qt5::DBus
- telepathy-qt${QT_VERSION_MAJOR}
- ${TP_QT_LIBRARY_LINKER_FLAGS})
+ telepathy-qt${QT_VERSION_MAJOR})
# Set the correct version number
set_target_properties(telepathy-qt${QT_VERSION_MAJOR}-service PROPERTIES