summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2022-11-08Add support for additional buttons (side and extra)HEADmasterFrediano Ziglio1-13/+30
Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
2022-06-16ci: Fix autoconf AX_CXX_COMPILE_STDCXX_11 missing macroFrediano Ziglio1-1/+1
This fixes the issue during CI build: ./configure: line 5219: AX_CXX_COMPILE_STDCXX_11: command not found Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
2022-06-16Remove warning compilingFrediano Ziglio1-1/+2
Remove an alignment warning vdagent/vdagent.cpp: In member function 'bool VDAgent::handle_announce_capabilities(const VDAgentAnnounceCapabilities*, uint32_t)': vdagent/vdagent.cpp:1048:48: warning: taking address of packed member of 'VDAgentAnnounceCapabilities' may result in an unaligned pointer value [-Waddress-of-packed-member] 1048 | _client_caps.assign(announce_capabilities->caps, announce_capabilities->caps + caps_size); | ~~~~~~~~~~~~~~~~~~~~~~~^~~~ Not a real issue, just annoying. Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
2022-06-15CI: Use different image to avoid vcpkg updateFrediano Ziglio1-2/+2
vcpkg update is time consuming, just use a more recent version. Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
2022-06-15Do not force library prefix for MSVCFrediano Ziglio1-1/+3
Do not use Unix suffix under MSVC (for MingW is fine, not for Microsoft standards where .lib is used). Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
2021-01-20Better error reporting if zlib or libpng are not staticFrediano Ziglio1-1/+20
Tell the specific library which is not static. Previously any would be reported as libpng. This fixes https://gitlab.freedesktop.org/spice/win32/vd_agent/-/issues/17 Signed-off-by: Frediano Ziglio <freddy77@gmail.com> Acked-by: Jakub Janků <jjanku@redhat.com>
2020-11-04Use a different Chocolatey tool for ImageMagickFrediano Ziglio1-1/+2
imagemagick.tool is currently broken, use imagemagick. Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
2020-11-04Update spice-common submoduleFrediano Ziglio1-0/+0
This brings in the following changes: Frediano Ziglio (4): build: Do not use mingw_ninja_install macro in spec file Release 0.14.3 build-sys: post-release version bump to 0.14.4 protocol: Fix enumeration deprecation for Visual Studio Marc-André Lureau (1): vdagent: add a MonitorsMM field to VDAgentMonitorsConfig SimonP (1): protocol: Add support for side mouse buttons This update allow to fix an issue with Microsoft compiler. Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
2020-10-25Enable some security options on output executablesFrediano Ziglio1-3/+25
Enable NX (prevent data to be executable) and ASLR (address randomisation). Signed-off-by: Frediano Ziglio <fziglio@redhat.com> Acked-by: Uri Lublin <uril@redhat.com>
2020-07-31clipboard: enable copying files from client using webdavJakub Janků4-1/+194
When the user wants to copy files, new spice-gtk can share those files using the existing phodav server. In that case, it advertises the VD_AGENT_CLIPBOARD_FILE_LIST type in the clipboard grab message. Upon request of the clipboard data in the mentioned type, spice-gtk provides a list of absolute paths in the phodav server - these are the files that are supposed to be copied/moved. The role of the vdagent is to adjust this data given the drive letter of the mapped webdav share. Files can be both copied and moved, although move was tested only with Windows' File Explorer. Copying files from the vdagnet side to the client is not supported yet. Signed-off-by: Jakub Janků <jjanku@redhat.com> Acked-by: Frediano Ziglio <fziglio@redhat.com>
2020-07-03desktop_layout: Update container iteration syntaxFrediano Ziglio1-6/+2
Signed-off-by: Frediano Ziglio <freddy77@gmail.com> Acked-by: Julien Ropé <jrope@redhat.com>
2020-07-03Move set_display_depth from VDAgent to DesktopLayoutFrediano Ziglio3-21/+19
The function only change DesktopLayout. Signed-off-by: Frediano Ziglio <freddy77@gmail.com> Acked-by: Julien Ropé <jrope@redhat.com>
2020-07-03Minor style updateFrediano Ziglio1-1/+2
Signed-off-by: Frediano Ziglio <freddy77@gmail.com> Acked-by: Julien Ropé <jrope@redhat.com>
2020-06-15desktop_layout: Ignore Citrix Workspace displaysFrediano Ziglio1-0/+3
Citrix Workspace add 8 additional displays for off-line usage. Ignore them like for mirrored displays. This fixes https://gitlab.freedesktop.org/spice/win32/vd_agent/-/issues/8. Signed-off-by: Frediano Ziglio <freddy77@gmail.com> Acked-by: Julien Ropé <jrope@redhat.com>
2020-06-15desktop_layout: Factor out a function to enumerate displaysFrediano Ziglio1-21/+21
Reduce code duplication, the enumeration happens 3 times. Signed-off-by: Frediano Ziglio <freddy77@gmail.com> Acked-by: Julien Ropé <jrope@redhat.com>
2020-05-29display_configuration: Update log stringsFrediano Ziglio1-2/+2
For other strings resolution is reported as "WxH", no spaces around "x". Signed-off-by: Frediano Ziglio <freddy77@gmail.com> Acked-by: Francesco Giudici <fgiudici@redhat.com>
2020-05-25file_xfer: Return detailed error for invalid filenameFrediano Ziglio1-0/+4
A literal constant is used for error type as the project is not dependent on glib2 and that Visual Studio and CMake are supported so it would make the compilation on some environment more complicated than actually is just for a constant. Signed-off-by: Frediano Ziglio <fziglio@redhat.com> Acked-by: Kevin Pouget <kpouget@redhat.com> Acked-by: Victor Toso <victortoso@redhat.com>
2020-05-22desktop_layout: Use MutexLocker for lock/unlockFrediano Ziglio1-8/+3
Reduce code and avoids to forget to unlock() in the future. Signed-off-by: Frediano Ziglio <freddy77@gmail.com> Acked-by: Kevin Pouget <kpouget@redhat.com>
2020-05-15vdagent: Reset properly state of pending large messages upon disconnectionFrediano Ziglio1-0/+1
If the client closes the connection while having pending large messages (split into multiple chunks) the state is not correctly reset causing next client messages to be not correctly handled. This can occur for instance if the client is closed (or killed) while transferring a large file. This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1548419. Signed-off-by: Frediano Ziglio <freddy77@gmail.com> Acked-by: Victor Toso <victortoso@redhat.com>
2020-05-15Use final capabilities to check client messagesFrediano Ziglio1-10/+24
The client is sending messages that are compatible with agent capabilities but also encoded with capabilities it knows of so to check them we need to consider final capabilities, not client ones. This fixes a regression introduced with "vdagent: Reuse agent_check_message" where some messages were wrongly interpreted as wrong (particularly some clipboard messages). Signed-off-by: Frediano Ziglio <freddy77@gmail.com> Acked-by: Jakub Janků <jjanku@redhat.com>
2020-04-28cmake: Force static librariesFrediano Ziglio1-0/+6
Add some settings to both MingW and MSVC to more strongly force static libraries linking. Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
2020-04-28ci: Use magick.exe executable under WindowsFrediano Ziglio1-10/+8
On Windows beside the various single executables like Linux there's a single "magick" executable you can use specifying what you want to do. Having a single executable avoids the trick to fix "convert" problem and is easier to port, you just have to copy the single executable. Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
2020-04-28vdagent: Reuse agent_check_messageFrediano Ziglio1-51/+15
That function does also more checks on the message. Signed-off-by: Frediano Ziglio <fziglio@redhat.com> Acked-by: Jakub Janků <jjanku@redhat.com>
2020-04-24Use SPICE_N_ELEMENTS instead of a constant for file_path sizeFrediano Ziglio1-2/+4
Allows to easily change the size if needed Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
2020-04-24file_xfer: Return detailed error for no spaceFrediano Ziglio1-0/+3
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
2020-04-24vdagent: Return better error if lockedFrediano Ziglio1-1/+1
Use specific VD_AGENT_FILE_XFER_STATUS_SESSION_LOCKED error. Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
2020-04-24vdagent: Allow to return detailed message for file transferFrediano Ziglio3-23/+33
Reuse AgentFileXferStatusMessageFull and agent_prepare_filexfer_status Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
2020-04-24Compile in agent utilities from spice-commonFrediano Ziglio4-1/+10
Allows these utilities to be used in the code. Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
2020-04-01spice-protocol: Update to get new message definitionsFrediano Ziglio4-4/+14
The EXTRA_DIST part in Makefile.am is needed as spice-protocol removed support for Autoconf. We don't need anymore "ignore=untracked" in the submodule as we are not going to add or modify files anymore. Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
2020-04-01ci: Use a single jobFrediano Ziglio1-7/+5
Reduce CI resource usage using a single job instead of 2. The project is pretty small and the setup of the 2 jobs is pretty long compared to the build so using a single job (we used the same container image for both) reduce CI resource usage. Signed-off-by: Frediano Ziglio <fziglio@redhat.com> Acked-by: Victor Toso <victortoso@redhat.com>
2020-04-01ci: Fix repositories updatesFrediano Ziglio1-2/+2
Force sync and update of all git submodules. Do not install packaged spice-protocol, we are using submodule. Signed-off-by: Frediano Ziglio <fziglio@redhat.com> Acked-by: Victor Toso <victortoso@redhat.com>
2020-03-30Revert 3 last patchesFrediano Ziglio5-12/+11
Revert "try to remove other bugs", commit 57266085b9d68474f4006e09dece5945e5f8cc82. Revert "try to fix previous", commit 8e4037706841a89915ccb0db84e4b336433027eb. Revert "attempt to fix more warnings!", commit 66b6933a388b222cb9ffa510401bf2485d4e6f2e. I put by mistake on the MR due to some automatic scripts. Their state are pretty experimental. Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
2020-03-23try to remove other bugsFrediano Ziglio1-1/+1
2020-03-23try to fix previousFrediano Ziglio5-10/+10
2020-03-23attempt to fix more warnings!Frediano Ziglio4-10/+11
2020-03-23display_setting: Remove a warningFrediano Ziglio1-1/+1
Avoids: warning C4267: 'initializing': conversion from 'size_t' to 'DWORD', possible loss of data Value won't never be that huge to cause overflow (we are reading a string in a static buffer, we don't expect an encyclopedia). Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
2020-03-23file_xfer: Remove a warningFrediano Ziglio1-1/+1
Avoids: warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
2020-03-19build: Add missing file to distributionFrediano Ziglio1-0/+1
test-shell script is needed for "make check". Signed-off-by: Frediano Ziglio <fziglio@redhat.com> Acked-by: Uri Lublin <uril@redhat.com>
2020-03-19spec file: add msi installersUri Lublin1-0/+13
Signed-off-by: Uri Lublin <uril@redhat.com> Acked-by: Frediano Ziglio <fziglio@redhat.com>
2020-03-19Ignore spice-protocol untracked filesUri Lublin1-0/+1
This will help with making a release. spice-protocol's .gitignore is generated and not committed, so after running ./autogen.sh (autoreconf) git thinks spice-protocol is dirty (just because of generated files). Signed-off-by: Uri Lublin <uril@redhat.com> Acked-by: Frediano Ziglio <fziglio@redhat.com>
2020-03-19MSI: Make SourceDir the path to executablesUri Lublin2-4/+3
Make it possible to not put the executables under bin/ Signed-off-by: Uri Lublin <uril@redhat.com> Acked-by: Frediano Ziglio <fziglio@redhat.com>
2020-03-19MSI: Package: only allow perMachine installationUri Lublin1-1/+2
When building on Windows with Wix, also add Platform to Package as follows (wixl warns about it): Platform="$(var.Arch)" Signed-off-by: Uri Lublin <uril@redhat.com> Acked-by: Frediano Ziglio <fziglio@redhat.com>
2020-01-10Constification, does not make sense to change the messages processing themFrediano Ziglio1-19/+19
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
2019-12-16build: Remove unneeded library from linkingFrediano Ziglio1-3/+0
GetFileVersion* functions are not used. Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
2019-12-16build: Install binaries in CMakeFrediano Ziglio1-0/+2
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
2019-12-12vdservice: Print error on standard error, not standard outputFrediano Ziglio1-13/+13
Error stream should be used for error reporting, not output one. Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
2019-12-11Remove Visual Studio project filesFrediano Ziglio4-852/+0
These project files were not correctly tested and updated for a while. Now that CMake is present it can be used to generate proper updated Visual Studio projects instead. Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
2019-12-06build: Do not generate CMake config.h in source directoryFrediano Ziglio3-5/+5
Allows to build out-of-tree and have a clean working directory. Autoconf used to work with out-of-tree and "config.h" in the build directory as a "common" directory in the build directory was created, so including "../config.h" in version.rc and having "-I $(top_builddir)/common" used to work. CMake does not create "common" under the build directory so the "../config.h" inclusion fails. Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
2019-12-06ci: Add testing to CMakeFrediano Ziglio3-3/+80
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
2019-12-06build: Generate config.h from CMakeFrediano Ziglio1-0/+40
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-14 00:49:08 +0000