diff options
| author | Frediano Ziglio <fziglio@redhat.com> | 2018-01-22 17:18:23 +0000 |
|---|---|---|
| committer | Frediano Ziglio <fziglio@redhat.com> | 2018-01-31 13:39:54 +0000 |
| commit | 5d5a7bd181bacf33b6d9313050fb82a53c6f7cc1 (patch) | |
| tree | 2a827340a0a27d2c4f646d8e5a3640b7bd48322d | |
| parent | c4a0505f6edd6ddcc58c625de67945a227a2b8de (diff) | |
sound: Avoid cast that could cause alignment problems
clang is reporting:
sound.c:292:16: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'uint32_t *' (aka 'unsigned int *') increases required alignment from 1 to 4 [-Werror,-Wcast-align]
data = (uint32_t *)packet->data;
^~~~~~~~~~~~~~~~~~~~~~~~
however we are using memcpy to access "data" pointer so there's no
need to use uint32_t pointer. Also considering we don't do math with
that pointer.
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Victor Toso <victortoso@redhat.com>
| -rw-r--r-- | server/sound.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/server/sound.c b/server/sound.c index 8ba2485c..e3891d2c 100644 --- a/server/sound.c +++ b/server/sound.c @@ -281,7 +281,7 @@ static bool snd_record_handle_write(RecordChannelClient *record_client, size_t s { SpiceMsgcRecordPacket *packet; uint32_t write_pos; - uint32_t* data; + uint8_t* data; uint32_t len; uint32_t now; @@ -292,7 +292,7 @@ static bool snd_record_handle_write(RecordChannelClient *record_client, size_t s packet = (SpiceMsgcRecordPacket *)message; if (record_client->mode == SPICE_AUDIO_DATA_MODE_RAW) { - data = (uint32_t *)packet->data; + data = packet->data; size = packet->data_size >> 2; size = MIN(size, RECORD_SAMPLES_SIZE); } else { @@ -301,7 +301,7 @@ static bool snd_record_handle_write(RecordChannelClient *record_client, size_t s if (snd_codec_decode(record_client->codec, packet->data, packet->data_size, record_client->decode_buf, &decode_size) != SND_CODEC_OK) return false; - data = (uint32_t *) record_client->decode_buf; + data = record_client->decode_buf; size = decode_size >> 2; } |