diff options
| author | Frediano Ziglio <freddy77@gmail.com> | 2020-04-29 15:09:13 +0100 |
|---|---|---|
| committer | Frediano Ziglio <freddy77@gmail.com> | 2020-09-17 06:46:57 +0100 |
| commit | 762e0abae36033ccde658fd52d3235887b60862d (patch) | |
| tree | df4e3849591325361a0e70ab4680ae6d6dadc239 | |
| parent | fa0c199d3307e05eb7214ba598bf78a952ee4691 (diff) | |
quic: Check we have some data to start decoding quic image
All paths already pass some data to quic_decode_begin but for the
test check it, it's not that expensive test.
Checking for not 0 is enough, all other words will potentially be
read calling more_io_words but we need one to avoid a potential
initial buffer overflow or deferencing an invalid pointer.
Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Acked-by: Uri Lublin <uril@redhat.com>
| -rw-r--r-- | common/quic.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/common/quic.c b/common/quic.c index e2dee0f..bc753ca 100644 --- a/common/quic.c +++ b/common/quic.c @@ -1136,7 +1136,7 @@ int quic_decode_begin(QuicContext *quic, uint32_t *io_ptr, unsigned int num_io_w int channels; int bpc; - if (!encoder_reset(encoder, io_ptr, io_ptr_end)) { + if (!num_io_words || !encoder_reset(encoder, io_ptr, io_ptr_end)) { return QUIC_ERROR; } |