diff options
| author | Sumit Bose <sbose@redhat.com> | 2022-09-15 18:24:16 +0200 |
|---|---|---|
| committer | Sumit Bose <sbose@redhat.com> | 2022-09-16 14:16:48 +0200 |
| commit | 0e1aafad7da78ded9ed45fd0638c42876d2a8d6a (patch) | |
| tree | d344cc8d144d9e545487f3a9a1338d48cae1b3ad | |
| parent | d4a898303957f45ff8662885062d4699e9d89937 (diff) | |
adenroll: write SID before secret to Samba's db
Looks like 'net changesecretpw' expects the SID entry to be present to
work correctly. This patch will set the SID before trying to set the
machine account password.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1991619
| -rw-r--r-- | library/adenroll.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/library/adenroll.c b/library/adenroll.c index 9a06d52..ef60e2c 100644 --- a/library/adenroll.c +++ b/library/adenroll.c @@ -2245,13 +2245,6 @@ update_samba_data (adcli_enroll *enroll) } argv_sid[0] = argv_pw[0]; - _adcli_info ("Trying to set Samba secret."); - ret = _adcli_call_external_program (argv_pw[0], argv_pw, - enroll->computer_password, NULL, NULL); - if (ret != ADCLI_SUCCESS) { - _adcli_err ("Failed to set Samba computer account password."); - } - argv_sid[2] = (char *) adcli_conn_get_domain_sid (enroll->conn); if (argv_sid[2] == NULL) { _adcli_err ("Domain SID not available."); @@ -2265,6 +2258,13 @@ update_samba_data (adcli_enroll *enroll) } } + _adcli_info ("Trying to set Samba secret."); + ret = _adcli_call_external_program (argv_pw[0], argv_pw, + enroll->computer_password, NULL, NULL); + if (ret != ADCLI_SUCCESS) { + _adcli_err ("Failed to set Samba computer account password."); + } + return ret; } |