diff options
| author | Hans de Goede <hdegoede@redhat.com> | 2020-02-18 22:03:58 +0100 |
|---|---|---|
| committer | Hans de Goede <jwrdegoede@fedoraproject.org> | 2020-03-11 19:22:31 +0000 |
| commit | 50c619ed41caf5b9bf347c5d5929d4e5cfff4d11 (patch) | |
| tree | 6f9edd9076501fd9ec59026b7150f6cecd258d36 /themes | |
| parent | 16997ce639dae7bbe991f1a4ada45ec65bf66433 (diff) | |
two-step: Add UseEndAnimation setting
We try to start the end animation early based on our progress accounting
but this is highly unreliable because e.g.:
-It counts time to enter the diskcrypt passwd as normal boot time, while
this varies wildly from boot to boot
-Boot times for laptops can differ significantly between docked / undocked
state
Between gdm calling /bin/plymouth deactivate and the drm plugin's deactivate
method getting called there can be e.g. 2.1 seconds (from a random boot),
with a theoretical maximum of 3 seconds (2 seconds to finish the throbber +
1 second for the end animation).
On a modern system userland boot should be able to finish in say 5 seconds,
making gdm wait an additional 1 - 3 seconds for deactivation is a huge amount
of extra wait time!
This commit adds a new "UseEndAnimation" option to the two-step plugin,
which defaults to true. Setting this to false makes deactivation immediate.
This works nicely with the spinner (and bgrt) themes since we do not really
do anything special in the end animation there anyways and since we fade-over
into gdm things will still look ok, while shaving a signifcant chunk of our
boot time.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Diffstat (limited to 'themes')
| -rw-r--r-- | themes/bgrt/bgrt.plymouth.in | 3 | ||||
| -rw-r--r-- | themes/spinner/spinner.plymouth.in | 9 |
2 files changed, 12 insertions, 0 deletions
diff --git a/themes/bgrt/bgrt.plymouth.in b/themes/bgrt/bgrt.plymouth.in index 6f4dc7f8..5455eb7c 100644 --- a/themes/bgrt/bgrt.plymouth.in +++ b/themes/bgrt/bgrt.plymouth.in @@ -25,12 +25,15 @@ DialogClearsFirmwareBackground=true MessageBelowAnimation=true [boot-up] +UseEndAnimation=false UseFirmwareBackground=true [shutdown] +UseEndAnimation=false UseFirmwareBackground=true [reboot] +UseEndAnimation=false UseFirmwareBackground=true [updates] diff --git a/themes/spinner/spinner.plymouth.in b/themes/spinner/spinner.plymouth.in index f3abdab0..0687d125 100644 --- a/themes/spinner/spinner.plymouth.in +++ b/themes/spinner/spinner.plymouth.in @@ -23,6 +23,15 @@ ProgressBarBackgroundColor=0x606060 ProgressBarForegroundColor=0xffffff MessageBelowAnimation=true +[boot-up] +UseEndAnimation=false + +[shutdown] +UseEndAnimation=false + +[reboot] +UseEndAnimation=false + [updates] SuppressMessages=true ProgressBarShowPercentComplete=true |