Turn UpdatePackage() into UpdatePackages() - this lets us do some cool things

like only update security updates and also select the updates individually in
pk-update-viewer.

1 files changed, 2 insertions, 9 deletions

diff --git a/HACKING b/HACKING
index 02fade907..8a71c416e 100644
--- a/HACKING
+++ b/HACKING
@@ -20,21 +20,14 @@ In the C files use the following convention.
 The number of spaces and tabs are very important!
 
 	/* map the roles to policykit rules */
-	if (role == PK_ROLE_ENUM_UPDATE_PACKAGE ||
+	if (role == PK_ROLE_ENUM_UPDATE_PACKAGES ||
 	    role == PK_ROLE_ENUM_UPDATE_SYSTEM) {
 		policy = "org.freedesktop.packagekit.update";
 	} else if (role == PK_ROLE_ENUM_REMOVE_PACKAGE) {
 		policy = "org.freedesktop.packagekit.remove";
 	}
 
-and please DO NOT use "!" for a null pointer or boolean - it's too easy to miss
-in an audit...
-
-	/* check the search term */
-	ret = pk_engine_search_check (search, error);
-	if (ret == FALSE) {
-		return FALSE;
-	}
+and please DO NOT use "!" for a null pointer check.
 
 Functions are nearly always the same format, gtk-doc is optional: