diff options
| author | Dave Airlie <airlied@redhat.com> | 2020-07-21 16:32:08 +1000 |
|---|---|---|
| committer | Marge Bot <eric+marge@anholt.net> | 2020-07-23 01:50:28 +0000 |
| commit | be6c53bb9d3dd0c48bf956d566006e3372fbfdc4 (patch) | |
| tree | df12fe754856e48d831eebca150e16d62ebb3016 /.gitlab-ci | |
| parent | 4d73988f6fef39e9263ec0bb49cd5efff68393bc (diff) | |
llvmpipe/ms: fix sign extension bug in rasterizer.
/glcts --deqp-surface-width=1024 --deqp-surface-height=64 --deqp-case=KHR-GL45.texture_view.view_sampling --deqp-surface-type=fbo
was failing but only for width 1024.
The test was filling a 4x4 ms texture, but leaving the viewport set to 1024x64.
This was resulting in this code incorrectly sign extending a value, and passing
it into the mask generator and getting the wrong values. Explicit cast
avoids the sign extension and fixes the above test.
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6006>
Diffstat (limited to '.gitlab-ci')
| -rw-r--r-- | .gitlab-ci/deqp-virgl-gl-fails.txt | 1 | ||||
| -rw-r--r-- | .gitlab-ci/piglit/quick_gl.txt | 6 |
2 files changed, 2 insertions, 5 deletions
diff --git a/.gitlab-ci/deqp-virgl-gl-fails.txt b/.gitlab-ci/deqp-virgl-gl-fails.txt index 92e0ea5a194..2da4026e53a 100644 --- a/.gitlab-ci/deqp-virgl-gl-fails.txt +++ b/.gitlab-ci/deqp-virgl-gl-fails.txt @@ -637,7 +637,6 @@ dEQP-GLES31.functional.draw_indirect.compute_interop.separate.drawelements_compu dEQP-GLES31.functional.draw_indirect.compute_interop.separate.drawelements_compute_data_and_indices dEQP-GLES31.functional.draw_indirect.compute_interop.separate.drawelements_compute_indices dEQP-GLES31.functional.draw_indirect.random.20 -dEQP-GLES31.functional.fbo.no_attachments.maximums.all dEQP-GLES31.functional.image_load_store.2d_array.atomic.add_r32i_result dEQP-GLES31.functional.image_load_store.2d_array.atomic.add_r32i_return_value dEQP-GLES31.functional.image_load_store.2d_array.atomic.add_r32ui_result diff --git a/.gitlab-ci/piglit/quick_gl.txt b/.gitlab-ci/piglit/quick_gl.txt index 4eadd739a31..b061a96afe6 100644 --- a/.gitlab-ci/piglit/quick_gl.txt +++ b/.gitlab-ci/piglit/quick_gl.txt @@ -769,8 +769,6 @@ spec/arb_texture_multisample/sample-position/16: skip spec/arb_texture_multisample/sample-position/32: skip spec/arb_texture_multisample/sample-position/6: skip spec/arb_texture_multisample/sample-position/8: skip -spec/arb_texture_multisample/texelfetch fs sampler2dms 4 1x130-501x130: fail -spec/arb_texture_multisample/texelfetch fs sampler2dms 4 1x71-501x71: fail spec/arb_texture_multisample/texelfetch/16-fs-isampler2dms: skip spec/arb_texture_multisample/texelfetch/16-fs-isampler2dmsarray: skip spec/arb_texture_multisample/texelfetch/16-fs-sampler2dms: skip @@ -1668,8 +1666,8 @@ wgl/wgl-sanity: skip summary: name: results ---- -------- - pass: 23029 - fail: 201 + pass: 23031 + fail: 199 crash: 0 skip: 1442 timeout: 0 |