diff options
| author | Rob Clark <rclark@redhat.com> | 2018-01-19 14:29:01 +0100 |
|---|---|---|
| committer | Thomas Hellstrom <thellstrom@vmware.com> | 2018-01-19 14:29:01 +0100 |
| commit | 4d6e523557131c8c81d312aab4cca711a866fc61 (patch) | |
| tree | 4e40da1fbd411e15391fc4969541037f9bf0a793 /vmwgfx_ldu.c | |
| parent | a5ef7fae0cc58ed6d95eb80f726e7fd78e04b543 (diff) | |
vmwgfx: fix memory corruption with legacy/sou connectors
It looks like in all cases 'struct vmw_connector_state' is used. But
only in stdu connectors, was atomic_{duplicate,destroy}_state() properly
subclassed. Leading to writes beyond the end of the allocated connector
state block and all sorts of fun memory corruption related crashes.
Signed-off-by: Rob Clark <rclark@redhat.com>
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
Diffstat (limited to 'vmwgfx_ldu.c')
| -rw-r--r-- | vmwgfx_ldu.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/vmwgfx_ldu.c b/vmwgfx_ldu.c index 93fbff5..4dba1f4 100644 --- a/vmwgfx_ldu.c +++ b/vmwgfx_ldu.c @@ -276,8 +276,8 @@ static const struct drm_connector_funcs vmw_legacy_connector_funcs = { .set_property = vmw_du_connector_set_property, .destroy = vmw_ldu_connector_destroy, .reset = vmw_du_connector_reset, - .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, - .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, + .atomic_duplicate_state = vmw_du_connector_duplicate_state, + .atomic_destroy_state = vmw_du_connector_destroy_state, .atomic_set_property = vmw_du_connector_atomic_set_property, .atomic_get_property = vmw_du_connector_atomic_get_property, }; |