summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGuilhem Moulin <guilhem@libreoffice.org>2023-05-06 14:08:30 +0200
committerGuilhem Moulin <guilhem@libreoffice.org>2023-05-06 14:09:54 +0200
commitb6f2a9fd5e5bb310b129dad527cf4821f5d21cdb (patch)
treed31cc8dbd92e4a5fb63ac29eaa46316b14f370cd
parenta4b3d6ec27ba565c8799f707d40261c8c07f97b3 (diff)
esc: Replace uses of ‘is’ with literals.
/usr/local/bin/esc-report.py:393: SyntaxWarning: "is" with a literal. Did you mean "=="? /usr/local/bin/bugzillaAutomation.py:91: SyntaxWarning: "is not" with a literal. Did you mean "!="?
-rwxr-xr-xesc-reporting/esc-report.py2
-rwxr-xr-xqa/bugzillaAutomation.py2
2 files changed, 2 insertions, 2 deletions
diff --git a/esc-reporting/esc-report.py b/esc-reporting/esc-report.py
index 4eac0169..8f830426 100755
--- a/esc-reporting/esc-report.py
+++ b/esc-reporting/esc-report.py
@@ -390,7 +390,7 @@ def gen_rowRegression(useHigh=False):
'BASIC', 'Writer/RTF', 'Writer', '', 'Chart', 'Extensions', 'Formula Editor',
'Impress Remote', 'Installation', 'Linguistic', 'Printing and PDF export',
'UI', 'filters and storage', 'framework', 'graphics stack', 'sdk']:
- if id is '' or id not in statList['data']['esc']['component'][vType]:
+ if id == '' or id not in statList['data']['esc']['component'][vType]:
vOpen = 0
else:
vOpen = statList['data']['esc']['component'][vType][id]
diff --git a/qa/bugzillaAutomation.py b/qa/bugzillaAutomation.py
index 5416eab4..14670d2d 100755
--- a/qa/bugzillaAutomation.py
+++ b/qa/bugzillaAutomation.py
@@ -91,7 +91,7 @@ def analyze_bugzilla(statList, bugzillaData, cfg):
'bisected' not in rowKeywords and 'preBibisect' not in rowKeywords and \
'bibisectNotNeeded' not in rowKeywords and 'notBibisectable' not in rowKeywords:
- if row['severity'] is not 'enhancement':
+ if row['severity'] != 'enhancement':
if row['op_sys'] in ["All", "Windows (All)", "Linux (All)", "macOS (All)"]:
statList['tagRegression']['add'][rowId] = 'bibisectRequest'
else: