Age | Commit message (Collapse) | Author | Files | Lines |
|
Detected by "cppcheck"
Please CC: comments.
Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
Signed-off-by: Danny Kukawka <danny.kukawka@web.de>
|
|
Don't close file descriptor twice. Adopted version of a patch from
Thomas Jarosch <thomas.jarosch@intra2net.com>.
|
|
Fixed typo from commit c648362a711.
|
|
Fixed some compiler warnings (strict-aliasing etc.).
|
|
|
|
The hald-probe-video4linux prober supports both v4l1 and v4l2. Support for v4l1
has been removed from Linux kernel 2.6.38. Instead of disabling the prober
altogether, #ifdef the v4l1 parts when building on a newer kernel.
Signed-off-by: Martin Pitt <martin.pitt@ubuntu.com>
|
|
The old v4l1 API is gone from current kernels (2.6.38), and thus
linux/videodev.h does not exist any more. Add a configure check for the include
and do not build hald-probe-video4linux if it is not available.
|
|
|
|
Fixed probing of optical disc volumes by ignoring raid.
Calling "blkid -p -u raid /dev/sr0" blocks the dvd-drive as the
same as hal does. Note that "blkid -p -u filesystem,crypto,other
/dev/sr0" or "blkid -p -u noraid /dev/sr0" don't hang and return
the detected filesystem.
This is a patch that filter out the raid detection on disk volumes
so hal can detect the filesystem and mount the disk.
fd.o#15335
|
|
Fixed hal segfault. It crashes because strlen() gets called with a
NULL pointer (ppdev_compute_udi calls hal_util_get_last_element
with a NULL pointer).
bnc#556485
|
|
With new device-mapper udev rules are /dev/mapper/* symlinks
to basic device name /dev/dm-X.
(Change requested by udev upstream.)
This change breaks temporary-cryptsetup workaround inside hal.
With new dm-udev rules (uncluded since device-mapper 1.02.39)
there is DM_UDEV_DISABLE_OTHER_RULES_FLAG variable
which controls that scan should be ignored for this device
(it is set for all internal devices, including temporary cryptsetup,
internal parts of lvm devices etc.)
Ignore device if this flag is set.
See bugs
https://bugzilla.redhat.com/show_bug.cgi?id=613909
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=586286
Signed-off-by: Milan Broz <mbroz@redhat.com>
|
|
|
|
This is something I had to do in RHEL6, and so it made sense
to share with upstream, even though another HAL release might
not be likely.
|
|
Minor fix for d5f236f3dad5e721f8c2105b49c963839f3ce549.
|
|
Detect also machines with serial (wacom?) tablets and pnp-id FUJ02e7/FUJ02e9
as TabletPCs. Reduce detection of Wacom PNP-id to 'WACf' to prevent future
changes.
|
|
Detect also machines with serial wacom tablets and pnp-id > WACf009
as e.g. WACf010 as TabletPCs.
|
|
Fixed hotplug support for e-SATA from commit dea5997df8966719
(bnc#576506 and bnc#590163).
|
|
Added new prober to get the results of lsb_release. Parse
the output and add these new keys:
- system.lsb.version
- system.lsb.distributor_id
- system.lsb.description
- system.lsb.release
- system.lsb.codename
|
|
Added new key scsi.transport for SCSI devices to identify e.g.
FiberChannel, iSCSI or SAS. This allow to handle them in FDI
files (e.g. set volume.ignore or storage.automount_enabled_hint).
|
|
Fixed storage.bus handling for SCSI. Prevent fall through to PCI as
storage bus. Current HAL marked SCSI storage devices which are not
usb or ieee1394 get marked with storage.bus=pci and not as scsi.
|
|
Added *.orig to hald/linux/.gitignore
|
|
Add hotplug support for e-SATA (bnc#576506); hotpluggable flag
is set if ahci_cmd_port is exported in sysfs (available in the
recent kernel)
|
|
Fix drm_compute_udi() to prevent such udi's:
/org/freedesktop/Hal/devices/pci_1002_71c5_drm__null__card0
Use drm.dri_library only if the property is really set.
|
|
Changed event_io() to always use the same exit and cleanup.
|
|
Some BIOSe are broken and create infinite key press events for
the sleep key (FN-F5). So ignore all key repeats for the SLEEP
key. (bnc#525959)
|
|
|
|
The second argument of ioperm() is not the last port to be accessed
but rather length of the port range [port, port + len).
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Signed-off-by: Martin Pitt <martin.pitt@ubuntu.com>
|
|
If dbus_error_init() is not called before LIBHAL_FREE_DBUS_ERROR() is
called on that error, then it is uninitialized and may segfault. This
means that dbus_error_init() must be called before any "goto out" if
"out:" calls LIBHAL_FREE_DBUS_ERROR().
Signed-off-by: Martin Pitt <martin.pitt@ubuntu.com>
|
|
Do not crash on unhandled rules (bnc#537452)
|
|
|
|
retval 1 for LSB compliance
|
|
Now that the property names for USB interfaces have been fixed, correct
the environment variable names.
|
|
USB interfaces in hal should have usb.X for properties, compared to
usb_device for the parent.
|
|
Use the correct macros for kFreeBSD.
|
|
Check for availability of libufs on (k)freebsd and compile the code
conditionally.
|
|
Some bits in the code use realpath() with destination paths of size
HAL_PATH_MAX. This potentially breaks on systems where PATH_MAX is bigger than
HAL_PATH_MAX (which was 512 until now).
Since we can't use PATH_MAX directly (due to platforms like GNU/Hurd, which
apparently don't have it), just bump HAL_PATH_MAX to 4096 (as PATH_MAX is on
Linux), to avoid potential buffer overflows and also fix hal on Linux when
enabling FORTIFY in gcc.
https://bugs.freedesktop.org/show_bug.cgi?id=25888
|
|
it may happen in the out: case that LIBHAL_FREE_DBUS_ERROR (&error) is
called before the error structure is initialized via
dbus_error_init (&error). This could lead to a segfault during startup
as seen in dmesg:
|Intel AES-NI instructions are not detected.
|padlock: VIA PadLock not detected.
|hald-probe-inpu[1793]: segfault at 2 ip 00007f656fb68969 sp 00007fff39eeb950 error 4 in libc-2.10.2.so[7f656faf3000+14a000]
|hald-probe-inpu[1796]: segfault at 2 ip 00007fa2c3293969 sp 00007fffd92a5dd0 error 4 in libc-2.10.2.so[7fa2c321e000+14a000]
|hald-probe-inpu[1797]: segfault at 2 ip 00007f1d08ba2969 sp 00007fff34244e30 error 4 in libc-2.10.2.so[7f1d08b2d000+14a000]
|hald-probe-inpu[1799]: segfault at 2 ip 00007f35c0e3d969 sp 00007fffe5ec7ee0 error 4 in libc-2.10.2.so[7f35c0dc8000+14a000]
|hald-probe-inpu[1800]: segfault at 2 ip 00007f931c556969 sp 00007fffe1825b60 error 4 in libc-2.10.2.so[7f931c4e1000+14a000]
|hald-probe-inpu[1801]: segfault at 2 ip 00007f5156d9a969 sp 00007fff4e620af0 error 4 in libc-2.10.2.so[7f5156d25000+14a000]
|RPC: Registered udp transport module.
|RPC: Registered tcp transport module.
What I run into seems to be reported as Debian #562068 [0]. This patch
makes the segfault go away on my machine.
[0] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=562068
Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Signed-off-by: Martin Pitt <martin.pitt@ubuntu.com>
|
|
* Add support for file systems with spaces in their label names.
* Ignore ufsid labels outright. These labels are special since they are
created and destroyed based on whether or not the underlying device is
mounted or not. This should fix some weird remounting problems with UFS
volumes as well as some mount contention.
* Attempt to workaround the GEOM lock race by sleeping half of a second
when a DESTROY event is seen by the storage subsystem. Additionally, protect
against kern.geom.conftxt returning NULL. When this happens, all disks
would get removed, and that's bad.
|
|
* Fix support for the dynamic UFSID labels.
* Do not crash on an assertion due to a "dirty" DBusError object.
|
|
Do not use a freed pointer in the Fuse support code.
|
|
* Allow the newusb module to compile with the recent input changes from
kFreeBSD.
* Make sure usb2 devices attach properly to the device tree with the correct
parent.
* Properly detect when newusb devices are added and removed.
|
|
* Remove needless uses of hfp_error which can help avoid assertion
crashes.
* Reduce the number of times storage devices are refreshed.
* Allow hald to forcibly unmount devices which disappear.
|
|
BTN_TOUCH (as well as ABS_PRESSURE) is used not only by touchpads but
by touchscreens as well. The proper ceck for a touchpad is presence
of BTN_TOOL_FINGER and absence of BTN_TOOL_PEN (the latter to filter
out some tablets that use BTN_TOOL_FINGER).
Tablet matching should be on either BTN_TOOL_PEN or BTN_STYLUS.
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
|
|
Fixed indentation in device.c
|
|
Small performance fix, don't strcasecmp() if result already known,
because we have set a special string.
|
|
Fixed small compiler warning.
|
|
Fixed possible sscanf() crashes caused by hal_util_get_last_element()
returning a NULL pointer (in rare error case) which was used unchecked
in sscanf() calls.
|
|
Added more strlen related NULL pointer checks.
|
|
Added some checks for NULL pointer in util.c to prevent
trouble with crash in strlen caused by NULL pointer.
|
|
|