summaryrefslogtreecommitdiff
path: root/libhal
diff options
context:
space:
mode:
authorDanny Kukawka <danny.kukawka@web.de>2007-04-18 15:17:18 -0400
committerDavid Zeuthen <davidz@redhat.com>2007-04-18 15:17:18 -0400
commit49f699f3c2ea38fbfe1f75b004a5917ac482fe98 (patch)
treece3cb4683528973bb50a83df45f56b040e3d430b /libhal
parentb0e7e06138994fac45d08774a20774d04e8245de (diff)
fix possible segfault in probe-volume if vid->type == NULL
Fix possible segfaults in probe-volume and libhal if vid->type == NULL. Adde d checks for vid->type != NULL to probe-volume.c and new checks for parameter (LIBHAL_CHECK_PARAM_VALID) of libhal_changeset_set_property_string(). This fix also fd.o bug #10429.
Diffstat (limited to 'libhal')
-rw-r--r--libhal/libhal.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/libhal/libhal.c b/libhal/libhal.c
index 4ddac9e4..fb9800a8 100644
--- a/libhal/libhal.c
+++ b/libhal/libhal.c
@@ -3810,6 +3810,9 @@ libhal_changeset_set_property_string (LibHalChangeSet *changeset, const char *ke
{
LibHalChangeSetElement *elem;
+ LIBHAL_CHECK_PARAM_VALID(key, "*key", FALSE);
+ LIBHAL_CHECK_PARAM_VALID(value, "*value", FALSE);
+
elem = calloc (1, sizeof (LibHalChangeSetElement));
if (elem == NULL)
goto out;