summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDoug Nazar <nazard@nazar.ca>2021-05-04 20:45:19 -0400
committerGStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org>2021-05-05 10:02:48 +0000
commit4c6e57ad33ca99cb3913a96a86c53926ba5abf32 (patch)
tree39d47fbfebe7e9a5af5207fd4752f940b9c11c6b
parent5f5b812844aff139960a453828018e7bf6bf3c58 (diff)
rtsp-client: fix leak adding headers
gst_rtsp_message_add_header() makes a copy of the header, instead of taking ownership. Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-rtsp-server/-/merge_requests/204>
-rw-r--r--gst/rtsp-server/rtsp-client.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/gst/rtsp-server/rtsp-client.c b/gst/rtsp-server/rtsp-client.c
index 8312e3c..e5a62c0 100644
--- a/gst/rtsp-server/rtsp-client.c
+++ b/gst/rtsp-server/rtsp-client.c
@@ -3018,7 +3018,8 @@ handle_setup_request (GstRTSPClient * client, GstRTSPContext * ctx)
(gdouble) seekable / GST_SECOND);
gst_rtsp_message_add_header (ctx->response, GST_RTSP_HDR_MEDIA_PROPERTIES,
- g_string_free (media_properties, FALSE));
+ media_properties->str);
+ g_string_free (media_properties, TRUE);
/* TODO Check how Accept-Ranges should be filled */
gst_rtsp_message_add_header (ctx->request, GST_RTSP_HDR_ACCEPT_RANGES,
"npt, clock, smpte, clock");