ges: Move TimeOverlayClip out of GESTestClip

This was complexifying the implementation for very little gain.
Each source type should ideally have its own API.

In that patch we make it so we do not have to subclass anything
but instead use GESAsset to pass information about how the pipeline
should look like.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/175>

5 files changed, 14 insertions, 14 deletions

diff --git a/tests/check/ges/clip.c b/tests/check/ges/clip.c
index 9a1ad34b..37bfaa93 100644
--- a/tests/check/ges/clip.c
+++ b/tests/check/ges/clip.c
@@ -3999,7 +3999,7 @@ GST_START_TEST (test_copy_paste_children_properties)
 
   timeline = ges_timeline_new_audio_video ();
   layer = ges_timeline_append_layer (timeline);
-  clip = GES_TIMELINE_ELEMENT (ges_test_clip_new ());
+  clip = GES_TIMELINE_ELEMENT (ges_source_clip_new_time_overlay ());
   assert_set_duration (clip, 50);
 
   fail_unless (ges_layer_add_clip (layer, GES_CLIP (clip)));
diff --git a/tests/check/scenarios/check_edit_in_frames_with_framerate_mismatch.scenario b/tests/check/scenarios/check_edit_in_frames_with_framerate_mismatch.scenario
index 983e8dd1..a5bc6cc9 100644
--- a/tests/check/scenarios/check_edit_in_frames_with_framerate_mismatch.scenario
+++ b/tests/check/scenarios/check_edit_in_frames_with_framerate_mismatch.scenario
@@ -5,7 +5,7 @@ description, handles-states=true,
         "--videosink=fakesink"\
     }
 
-add-clip, name=clip, asset-id="framerate=120/1", layer-priority=0, type=GESTestClip, pattern=blue, duration=f240, inpoint=f100
+add-clip, name=clip, asset-id="time-overlay,framerate=120/1", layer-priority=0, type=GESSourceClip, pattern=blue, duration=f240, inpoint=f100
 set-child-properties, element-name=clip, time-mode=time-code
 pause
 
diff --git a/tests/check/scenarios/edit_while_seeked_with_stop.validatetest b/tests/check/scenarios/edit_while_seeked_with_stop.validatetest
index b2fc4e8c..a401abab 100644
--- a/tests/check/scenarios/edit_while_seeked_with_stop.validatetest
+++ b/tests/check/scenarios/edit_while_seeked_with_stop.validatetest
@@ -12,11 +12,11 @@ meta,
         "$(validateflow), pad=videosink:sink, record-buffers=true, ignored-fields=\"stream-start={stream-id,group-id,stream}\"",
     }
 
-add-clip, name=c0, asset-id=GESTestClip, layer-priority=0, type=GESTestClip, start=0, duration=1.0
-set-child-properties, element-name=c0, pattern=blue, time-mode=time-code, valignment=center, halignment=center
+add-clip, name=c0, asset-id=time-overlay, layer-priority=0, type=GESSourceClip, start=0, duration=1.0
+set-child-properties, element-name=c0, pattern=blue, valignment=center, halignment=center, time-mode=time-code
 
-add-clip, name=c1, asset-id=GESTestClip, layer-priority=0, type=GESTestClip, start=1.0, duration=1.0
-set-child-properties, element-name=c1, pattern=red, time-mode=time-code, valignment=center, halignment=center
+add-clip, name=c1, asset-id=time-overlay, layer-priority=0, type=GESSourceClip, start=1.0, duration=1.0
+set-child-properties, element-name=c1, pattern=red, valignment=center, halignment=center, time-mode=time-code
 commit;
 play
 
diff --git a/tests/check/scenarios/seek_with_stop.check_clock_sync.validatetest b/tests/check/scenarios/seek_with_stop.check_clock_sync.validatetest
index c89266a2..a082a582 100644
--- a/tests/check/scenarios/seek_with_stop.check_clock_sync.validatetest
+++ b/tests/check/scenarios/seek_with_stop.check_clock_sync.validatetest
@@ -12,11 +12,11 @@ meta,
         "$(validateflow), pad=videosink:sink, record-buffers=true, ignored-fields=\"stream-start={stream-id,group-id,stream}\"",
     }
 
-add-clip, name=c0, asset-id=GESTestClip, layer-priority=0, type=GESTestClip, start=0, duration=1.0
-set-child-properties, element-name=c0, pattern=blue, time-mode=time-code, valignment=center, halignment=center
+add-clip, name=c0, asset-id=time-overlay, layer-priority=0, type=GESSourceClip, start=0, duration=1.0
+set-child-properties, element-name=c0, pattern=blue, valignment=center, halignment=center, time-mode=time-code
 
-add-clip, name=c1, asset-id=GESTestClip, layer-priority=0, type=GESTestClip, start=1.0, duration=1.0
-set-child-properties, element-name=c1, pattern=red, time-mode=time-code, valignment=center, halignment=center
+add-clip, name=c1, asset-id=time-overlay, layer-priority=0, type=GESSourceClip, start=1.0, duration=1.0
+set-child-properties, element-name=c1, pattern=red, valignment=center, halignment=center, time-mode=time-code
 commit;
 play
 
diff --git a/tests/check/scenarios/seek_with_stop.validatetest b/tests/check/scenarios/seek_with_stop.validatetest
index e6d85d0f..134f1263 100644
--- a/tests/check/scenarios/seek_with_stop.validatetest
+++ b/tests/check/scenarios/seek_with_stop.validatetest
@@ -11,11 +11,11 @@ meta,
         "$(validateflow), pad=audiosink:sink, record-buffers=true, ignored-fields=\"stream-start={stream-id,group-id,stream}, segment={position,}\"",
     }
 
-add-clip, name=c0, asset-id=GESTestClip, layer-priority=0, type=GESTestClip, start=0, duration=1.0
-set-child-properties, element-name=c0, pattern=blue, time-mode=time-code, valignment=center, halignment=center
+add-clip, name=c0, asset-id=time-overlay, layer-priority=0, type=GESSourceClip, start=0, duration=1.0
+set-child-properties, element-name=c0, pattern=blue, valignment=center, halignment=center, time-mode=time-code
 
-add-clip, name=c1, asset-id=GESTestClip, layer-priority=0, type=GESTestClip, start=1.0, duration=1.0
-set-child-properties, element-name=c1, pattern=red, time-mode=time-code, valignment=center, halignment=center
+add-clip, name=c1, asset-id=time-overlay, layer-priority=0, type=GESSourceClip, start=1.0, duration=1.0
+set-child-properties, element-name=c1, pattern=red, valignment=center, halignment=center, time-mode=time-code
 pause
 
 seek, start=0.0, stop=0.5, flags=accurate+flush