diff options
author | Reynaldo H. Verdejo Pinochet <reynaldo@collabora.com> | 2012-01-19 19:46:46 -0300 |
---|---|---|
committer | Reynaldo H. Verdejo Pinochet <reynaldo@collabora.com> | 2012-01-19 19:46:46 -0300 |
commit | 1ccad5a70d853886c50a73e5484a8d212cad184b (patch) | |
tree | 24c37a06d158295a3f5f1095e345bcb6ddd95909 | |
parent | 17bb1d7b3e7b21565a35831f678a4f16aae089fe (diff) |
Don't ignore value returned when registering fb
Act upon a posible error return from _device_register_framebuffer,
propagating the error accordingly.
-rw-r--r-- | sink/surfaceflingersink/gstsurfaceflingersink.c | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/sink/surfaceflingersink/gstsurfaceflingersink.c b/sink/surfaceflingersink/gstsurfaceflingersink.c index 5f40577..4355173 100644 --- a/sink/surfaceflingersink/gstsurfaceflingersink.c +++ b/sink/surfaceflingersink/gstsurfaceflingersink.c @@ -157,11 +157,14 @@ gst_surfaceflinger_sink_setcaps (GstBaseSink * bsink, GstCaps * vscapslist) surfacesink->width, surfacesink->height, surfacesink->pixel_format); /* register frame buffer */ - videoflinger_device_register_framebuffers (surfacesink->videodev, - surfacesink->width, surfacesink->height, surfacesink->pixel_format); - - GST_DEBUG_OBJECT (surfacesink, "gst_surfaceflinger_sink_setcaps return true"); - return TRUE; + if (videoflinger_device_register_framebuffers (surfacesink->videodev, + surfacesink->width, surfacesink->height, surfacesink->pixel_format) + != -1) + return TRUE; + + GST_ERROR_OBJECT (surfacesink, + "Unable to register framebuffer device with given caps"); + return FALSE; } |