summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPatrick Ohly <patrick.ohly@intel.com>2016-08-26 06:17:46 -0700
committerPatrick Ohly <patrick.ohly@intel.com>2016-09-20 04:47:49 -0700
commitde53f83ce49ee75ea5ae3d86ed12a42ce83db95c (patch)
treeccf90a6444ba925508bb873414878e119d70c535
parente26095449c5b55172b8c7bb4ece81de26e52b9e6 (diff)
syncsession.h: fix TDevInfResultsCommand::shrinkCommand()
In (probably mostly unused code?) the previous boolean result of getIncomingState() was compared against the enum, which looks wrong. Probably getIncomingState() was meant to return the enum. gcc6 warned about this: synccommand.cpp:4277:36: error: comparison of constant '1' with boolean expression is always false [-Werror=bool-compare] fSessionP->getIncomingState()>psta_init, // alerted only if init complete
-rwxr-xr-xsrc/sysync/syncsession.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/sysync/syncsession.h b/src/sysync/syncsession.h
index 5c00226..ad2fce1 100755
--- a/src/sysync/syncsession.h
+++ b/src/sysync/syncsession.h
@@ -350,7 +350,7 @@ public:
void DatastoreHadErrors(void) { fErrorItemDatastores++; }; // let session know that sync was ok, but some items had errors
bool outgoingMessageFull(void) { return fOutgoingMessageFull; }; // test if outgoing full
bool isInterrupedCmdPending(void) { return fInterruptedCommandP!=NULL; };
- bool getIncomingState(void) { return fIncomingState; };
+ TPackageStates getIncomingState(void) { return fIncomingState; };
// stop processing commands in this message
void AbortCommandProcessing(TSyError aStatusCode); // all further commands in message will be answered with given status
// returns remaining time for request processing [seconds]