Age | Commit message (Collapse) | Author | Files | Lines |
|
Previously, some places in Gabble which called
gabble_connection_get_handle_contact_capabilities() did not assume that
it never returns NULL. But (due to the implicit text caps for everyone)
it is guaranteed always to return a non-NULL array of capabilities, so
we can simplify the places that call it.
|
|
|
|
If we don't have presence for a contact, we do not have any capabilities
for them. But we always want to ensure that all contacts are capable of
IM. So, currently there is a special-case in the caps-gathering code: if
we have no presence, we only call _get_contact_capabilities on the IM
factory: its implementation of this virtual method, unlike all others,
doesn't care if it's passed a NULL set of caps. Otherwise, if we do have
a set of capabilities, we call gabble_connection_build_contact_caps(),
which is essentially a foreach over all channel managers, including the
IM factory.
I think it's neater to avoid the special case, and treat "no presence"
as equivalent (for capabilities purposes) to "presence with no caps".
|
|
This was Olli's idea. He claims that building the old-school signals
causes measurable CPU usage on accounts with lots of contacts (think:
Facebook). It certainly causes D-Bus spam.
Neither Telepathy-GLib nor TelepathyQt4 use this old interface. Empathy
doesn't, either. I think this should be safe.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=40598
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
|
|
WockyMuc has a property, :password, representing the current password
being used to join the MUC. GabbleMuc previously had a private variable,
'password', which was used for this. In the port to WockyMuc, setting
the private variable was removed, but it was still used when
re-attempting to join after a nick conflict.
(I think the password should be a parameter to a hypothetical
wocky_muc_join_async() which does all the nick conflict crap for you.
Having this as state that kicks around on the WockyMuc for ever is
bizarre—once you're in the room, you usually don't use the password,
unless you're the owner, in which case you can retrieve the current
password *which may be different*!)
This patch expunges the zombie private variable, and ensures
WockyMuc:password is only set when the user provides a password, not at
every join attempt. It adds a test for this case, and some of the basic
functionality of Password (which subsumes some incidental testing of the
Password interface in muc/presence-before-closing: the only test that
touched Password at all!).
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=39790
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
...and give back a new data form in the represent_client function.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
If a data form is bad we might not be able to, so we shouldn't crash.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
|
|
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
We want to be able to check that disco replies with data forms still
have the correct hash.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
g_slice_alloc() behavior for zero-sized blocks is undocumented and
leads to obscure code paths taken.
|
|
|
|
The intent is to make optional the dependency on libsoup (fd.o #40537).
|
|
|
|
camera for us
https://bugs.freedesktop.org/show_bug.cgi?id=40471
|
|
These aren't used yet.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
Let's add another "well-known" bundle
https://bugs.freedesktop.org/show_bug.cgi?id=36996
|
|
|
|
|
|
|
|
|
|
Conflicts:
NEWS
configure.ac
|
|
|
|
|
|
|
|
|
|
Conflicts:
NEWS
configure.ac
|
|
|
|
|
|
|
|
|
|
|
|
Reviewed-by: Simon McVittie (smcv) <simon.mcvittie@collabora.co.uk>
|
|
|
|
|
|
|
|
advertised
|
|
|
|
|
|
|
|
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
|
|
|